Skip to content

feat: lowercase headers to exclude in exapp proxy #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

kyteinsky
Copy link
Collaborator

@kyteinsky kyteinsky commented Apr 21, 2025

The headers to exclude in the app's manfest should be lowercase checked for convenience.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • lib/Controller/ExAppProxyController.php: Language not supported

@kyteinsky
Copy link
Collaborator Author

It is a feature but should be backported imo.

@oleksandr-nc
Copy link
Contributor

In my opinion, it's always better to do checks during the initialization process (to prevent invalid values ​​from being stored in the database - so we know that $route['headers_to_exclude'] is always valid), rather than checking at runtime to see if json_decode failed or not.


$headersToExclude = array_map('strtolower', $headersToExclude);

This is nice catch!

@kyteinsky
Copy link
Collaborator Author

In my opinion, it's always better to do checks during the initialization process (to prevent invalid values ​​from being stored in the database - so we know that $route['headers_to_exclude'] is always valid), rather than checking at runtime to see if json_decode failed or not.

yeah but json in a db column is tempting to adjust by hand. Okay let's not endorse that behaviour :)

@kyteinsky kyteinsky force-pushed the feat/lower-headers branch from d294547 to b7dcdd0 Compare April 22, 2025 08:55
@kyteinsky kyteinsky merged commit 404c157 into main Apr 22, 2025
36 checks passed
@kyteinsky kyteinsky deleted the feat/lower-headers branch April 22, 2025 12:57
@oleksandr-nc
Copy link
Contributor

@kyteinsky any backports?

@kyteinsky
Copy link
Collaborator Author

oops 😅

@kyteinsky
Copy link
Collaborator Author

/backport to stable31

@kyteinsky
Copy link
Collaborator Author

/backport to stable30

@kyteinsky
Copy link
Collaborator Author

/backport to stable29

@oleksandr-nc
Copy link
Contributor

/backport to stable31

Copy link

backportbot bot commented Apr 24, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/568/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7dcdd0e

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/568/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants