-
Notifications
You must be signed in to change notification settings - Fork 14
feat: lowercase headers to exclude in exapp proxy #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (1)
- lib/Controller/ExAppProxyController.php: Language not supported
It is a feature but should be backported imo. |
In my opinion, it's always better to do checks during the initialization process (to prevent invalid values from being stored in the database - so we know that $headersToExclude = array_map('strtolower', $headersToExclude); This is nice catch! |
yeah but json in a db column is tempting to adjust by hand. Okay let's not endorse that behaviour :) |
Signed-off-by: Anupam Kumar <[email protected]>
d294547
to
b7dcdd0
Compare
@kyteinsky any backports? |
oops 😅 |
/backport to stable31 |
/backport to stable30 |
/backport to stable29 |
/backport to stable31 |
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/568/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick b7dcdd0e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/568/stable31 Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The headers to exclude in the app's manfest should be lowercase checked for convenience.