fix(dashboard): performance and refactoring #41065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
added
bug
2. developing
ShGKme
requested review from
st3iny,
susnux,
JuliaKirschenheuter,
skjnldsv,
Pytal and
szaimen
Not ready for review? |
|
@ShGKme You might have accidentally committed a dev build :D |
st3iny
approved these changes
Oct 24, 2023
ShGKme
force-pushed
the
fix/dashboard--performance-and-refactoring
branch
from
86f8b4f to
da88d22
Compare
skjnldsv
added
3. to review
skjnldsv
reviewed
Oct 24, 2023
skjnldsv
reviewed
Oct 24, 2023
apps/dashboard/src/DashboardApp.vue
Outdated
Comment on lines
17
to
37
| <div v-for="panelId in layout" :key="panels[panelId].id" class="panel"> | ||
| <h2 class="panel__header"> | ||
| <span aria-hidden="true" class="panel__header-icon" :class="getWidgetIconClass(panels[panelId])" /> | ||
| {{ getWidgetTitle(panels[panelId]) }} | ||
| </h2> | ||
| <div class="panel__content" :class="{ loading: !isApiWidgetV2(panels[panelId].id) && !panels[panelId].mounted }"> | ||
| <ApiDashboardWidget v-if="isApiWidgetV2(panels[panelId].id)" | ||
| :widget="apiWidgets[panels[panelId].id]" | ||
| :data="apiWidgetItems[panels[panelId].id]" | ||
| :loading="loadingItems" /> | ||
| <div v-else :ref="panels[panelId].id" :data-id="panels[panelId].id" /> | ||
| </div> |
There was a problem hiding this comment.
Seeing the amount of scoping done here as well as methods used that could be computed, we would benefit from this being a chidren Vue Component directly :)
<ApiDashboardPanel v-for="panelId in layout"
:key="panels[panelId].id"
:panel="panels[panelId]" />
Pytal
approved these changes
Oct 26, 2023
ShGKme
added
2. developing
Merged
Merged
ShGKme
force-pushed
the
fix/dashboard--performance-and-refactoring
branch
from
da88d22 to
770f8d1
Compare
ShGKme
added
3. to review
skjnldsv
approved these changes
May 29, 2025
- `aria-labelledby` is not needed here, it is a hidden icon - `visually-hidden` has transformations that have huge performance impact in combination with other transformations, for example, on draggable Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
fix/dashboard--performance-and-refactoring
branch
from
770f8d1 to
a68cd1e
Compare
|
|
|
|
/backport 8ba8c26 to stable31 |
|
/backport 8ba8c26 to stable30 |
|
/backport 8ba8c26 to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Polish a bit dashboard app:
panel-activity--header--icon--descriptionand very nested selectors with selectors by tags.hidden-visuallyhas transforms that makes it terrible in performance with a combination of DraggableChecklist