Skip to content

apply theming to user mentions #4774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

apply theming to user mentions #4774

wants to merge 14 commits into from

Conversation

sowjanyakch
Copy link
Contributor

see comment #4672 (comment)

user_mentions

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review February 28, 2025 12:01
@sowjanyakch sowjanyakch self-assigned this Feb 28, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Feb 28, 2025
@sowjanyakch sowjanyakch changed the title theme user mentions apply theming to user mentions Feb 28, 2025
@mahibi mahibi force-pushed the mentions_colors branch from 4126bd2 to b059dcc Compare March 6, 2025 13:03
mahibi
mahibi requested changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments from Joas/Marcel M.

@mahibi
Copy link
Collaborator

mahibi commented Mar 6, 2025

i think it crashed for me one time when entering the chat but did not find the crashlog..

@nickvergessen nickvergessen linked an issue Mar 17, 2025 that may be closed by this pull request
Color mentions when user is part of the group or team #4805
Open
@sowjanyakch sowjanyakch force-pushed the mentions_colors branch 3 times, most recently from b2020cf to 3ba5d27 Compare March 19, 2025 10:21
@sowjanyakch sowjanyakch requested a review from mahibi March 19, 2025 10:22
@sowjanyakch sowjanyakch force-pushed the mentions_colors branch 2 times, most recently from 58324b7 to 0173bb5 Compare March 20, 2025 17:20
@sowjanyakch sowjanyakch force-pushed the mentions_colors branch 5 times, most recently from 9cdb59c to 0c1f54a Compare April 17, 2025 14:21
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4774-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

mahibi
mahibi requested changes Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fetching the user data on every opening of conversation list is still too much.

  • The DB scheme is missing multi user account handling, which would also require foreign keys etc to make sure data is correctly removed once a user account is removed etc

  • DB migration is missing at all

Also with improvements, please wait to merge this PR until i'm back from vacation so i can review again (as wrong database handling could lead to complex problems)

app/src/main/java/com/nextcloud/talk/api/NcApi.java
@@ -34,6 +34,8 @@
import com.nextcloud.talk.models.json.signaling.settings.SignalingSettingsOverall;
import com.nextcloud.talk.models.json.status.StatusOverall;
import com.nextcloud.talk.models.json.unifiedsearch.UnifiedSearchOverall;
import com.nextcloud.talk.models.json.usercircles.UserCirclesOverall;
import com.nextcloud.talk.models.json.usergroups.UserGroupsOverall;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused imports

@sowjanyakch sowjanyakch marked this pull request as draft June 2, 2025 13:41
@sowjanyakch
add endpoints
fe8f19b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add model
02b8ecd 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add copyright
9d834c2 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
theme user groups and mentions
c096c9b 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
modify ncApiCoroutines
5779dce 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
theme mention-all and remove unused code
82109fe 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
fix group mentions
d305132 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
store user groups and circles in room database
acee0a5 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
add copyright
2b29685 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
apply theming to user mentions
0a107c4 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
ktlintformat
17f4a20 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
refactor
e874502 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
logging info
b92020d 
Signed-off-by: sowjanyakch <[email protected]>
@sowjanyakch
detekt + merge conflicts
689f5ed 
Signed-off-by: sowjanyakch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@SystemKeeper SystemKeeper SystemKeeper left review comments

@mahibi mahibi mahibi requested changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

Requested changes must be addressed to merge this pull request.

Assignees

@sowjanyakch sowjanyakch

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color mentions when user is part of the group or team
4 participants
@sowjanyakch @mahibi @nickvergessen @SystemKeeper