Skip to content

move ks client reader to separated directory #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

miledxz
Copy link
Contributor

@miledxz miledxz commented Jan 14, 2025

Proposed changes

Problem: Adding update of ks client Reader interface and FakeReader into separated directory.

Solution: Moved files, updated import paths.

Closes #1573

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@miledxz miledxz requested a review from a team as a code owner January 14, 2025 20:13
Copy link
Contributor

github-actions bot commented Jan 14, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


Mile seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added the tests Pull requests that update tests label Jan 14, 2025
@miledxz
Copy link
Contributor Author

miledxz commented Jan 14, 2025

I have hereby read the F5 CLA and agree to its terms

@miledxz miledxz closed this Jan 14, 2025
@miledxz miledxz deleted the tests/add-update-ks-client-reader branch January 14, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use a common k8s API fake reader
1 participant