Skip to content

Set proper IP family policy on NGINX LB Service (#3475) #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2025

Conversation

sjberman
Copy link
Collaborator

@sjberman sjberman commented Jun 6, 2025

Problem: When provisioning the NGINX LoadBalancer Service, the IPFamily that's set in the NginxProxy resource (default dual) was not honored.

Solution: By default, set the IPFamily to PreferDualStack. If a user has specified otherwise in the NginxProxy resource, then set to SingleStack. The IPFamilies list is populated automatically by k8s based on the policy.

Problem: When provisioning the NGINX LoadBalancer Service, the IPFamily that's set in the NginxProxy resource (default dual) was not honored.

Solution: By default, set the IPFamily to PreferDualStack. If a user has specified otherwise in the NginxProxy resource, then set to SingleStack. The IPFamilies list is populated automatically by k8s based on the policy.
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (00e246f) to head (74d9027).
Report is 1 commits behind head on release-2.0.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-2.0    #3476   +/-   ##
============================================
  Coverage        86.77%   86.77%           
============================================
  Files              127      127           
  Lines            15068    15079   +11     
  Branches            62       62           
============================================
+ Hits             13075    13085   +10     
- Misses            1841     1842    +1     
  Partials           152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjberman sjberman enabled auto-merge (squash) June 6, 2025 18:56
@sjberman sjberman merged commit f250ec3 into release-2.0 Jun 6, 2025
63 of 64 checks passed
@sjberman sjberman deleted the cherry-pick/ipv6-fix branch June 6, 2025 19:25
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jun 6, 2025
@sjberman sjberman added the bug Something isn't working label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants