Skip to content

Use filepath tools for Windows compatibility #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

dareste
Copy link
Collaborator

@dareste dareste commented Jul 15, 2024

The PR uses filepath.ToSlash and filepath.Joinin order to be consistent with how supportpkg tarballs are created, regardless of the OS in which the plugin runs.

Needs Windows testing.

Closes #22

@dareste dareste requested a review from a team as a code owner July 15, 2024 16:49
@mrajagopal mrajagopal merged commit edc4529 into main Jul 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows plugin creates flattened tarballs
2 participants