Skip to content

Define Github actions permissions and sign assets #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 27, 2024
Merged

Define Github actions permissions and sign assets #49

merged 3 commits into from
Sep 27, 2024

Conversation

dareste
Copy link
Collaborator

@dareste dareste commented Sep 25, 2024 •
edited
Loading

Proposed changes

  • Explicitly establish permissions for github actions that didn't have them.
  • Sign assets via cosign.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@dareste dareste requested a review from a team as a code owner September 25, 2024 13:44
@dareste dareste changed the title Define Github actions permissions Define Github actions permissions and sign assets Sep 26, 2024
@dareste dareste merged commit 307593a into main Sep 27, 2024
3 checks passed
@dareste dareste deleted the areste-contributing branch September 27, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrajagopal mrajagopal mrajagopal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dareste @mrajagopal