Skip to content

Add step to get latest hugo theme version and set as ENV var #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

nginx-jack
Copy link
Collaborator

@nginx-jack nginx-jack commented Aug 14, 2024

Proposed changes

Gets the latest hugo theme version at workflow run time. This means we will not have to update all action callers when we have a new hugo theme.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)

@nginx-jack nginx-jack requested a review from a team as a code owner August 14, 2024 10:09
@nginx-jack nginx-jack force-pushed the latest-hugo-theme branch 2 times, most recently from f122b6e to ed34c0a Compare August 14, 2024 10:36
@mjang
Copy link

mjang commented Aug 14, 2024

Question, @nginx-jack . I was looking at this line, and wondering about the purpose of $GITHUB_ENV. (Why do we add the latest Hugo version number, among other things, to that variable.)

Copy link
Contributor

@lamATnginx lamATnginx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nginx-jack nginx-jack merged commit 48d3b52 into main Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants