This repository was archived by the owner on May 24, 2023. It is now read-only.
Update secret type of default secret to TLS #39
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update secret type of default secret to TLS
Upgrade nodes
the following upgrade notes will need to be added to the CHANGELOG/release notes.
To upgrade the NGINX Ingress Controller from versions 1.9.* to 1.10.0, perform the following prerequisite steps. The steps are necessary, as version 1.10.0 requires TLS secrets to be of the type
kubernetes.io/tls
.defaultSecret
field:Opaque
. The new secret is of the typekubernetes.io/tls
.defaultSecret
is set to some secret, make sure it is of the typekubernetes.io/tls
. If not, recreate the secret with the typekubernetes.io/tls
.wildcardTLS
is set to some secret, make sure it is of the typekubernetes.io/tls
. If not, recreate the secret with the typekubernetes.io/tls
.kubernetes.io/tls
, JWT secrets are of the typenginx.org/jwt
and CA secrets are of the typenginx.org/ca
. To avoid potential disruption of client traffic, instead of recreating the secrets, create new secrets with the correct type and update the Ingress/VirtualServer resources to use the new secrets.After performing the steps above, upgrade the Ingress Controller to version 1.10.0.