-
Notifications
You must be signed in to change notification settings - Fork 25
WIP: Add dwi workflows #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @josephmje, great job at solving conflicts. Now that this is in a sane state, could we maybe split this humongous PR into more digestible pieces? Otherwise, I can't commit to review this anytime soon. |
+1 Maybe we could start by getting all the infrastructure stuff (docs, CI, etc.) merged in first? And then, once that's in, start dealing with meat of it, bit by bit? |
+1 to the start with the infrastructure first - basically travis tests. I would hold documentation off just a little while because in nipreps/smriprep#65 we are testing the maintenance of documentation without readthedocs. That would allow going to the meat a bit faster :D |
+1 I've been finding more and more bugs with this PR so that's definitely for the better. Closing this. |
Hey @josephmje this (as in "further PRs") is awaiting nipy/nipype#3034 and nipy/nipype#3031, isn't it? |
@oesteban yes it is. But for now, I've got an |
To do: