Skip to content

WIP: Add dwi workflows #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 197 commits into from
Closed

WIP: Add dwi workflows #6

wants to merge 197 commits into from

Conversation

josephmje
Copy link
Collaborator

@josephmje josephmje commented Sep 8, 2019

To do:

  • remove unnessary changes
  • add CLI options previously in click to argparse
  • migrate fieldmap workflows to sdcflows
  • remove experimental synb0 steps

josephmje and others added 30 commits June 13, 2019 17:40
@oesteban
Copy link
Member

Hi @josephmje, great job at solving conflicts. Now that this is in a sane state, could we maybe split this humongous PR into more digestible pieces? Otherwise, I can't commit to review this anytime soon.

@arokem
Copy link
Collaborator

arokem commented Sep 12, 2019

+1 Maybe we could start by getting all the infrastructure stuff (docs, CI, etc.) merged in first? And then, once that's in, start dealing with meat of it, bit by bit?

@oesteban
Copy link
Member

+1 to the start with the infrastructure first - basically travis tests.

I would hold documentation off just a little while because in nipreps/smriprep#65 we are testing the maintenance of documentation without readthedocs.

That would allow going to the meat a bit faster :D

@josephmje
Copy link
Collaborator Author

+1 I've been finding more and more bugs with this PR so that's definitely for the better. Closing this.

@josephmje josephmje closed this Sep 13, 2019
@oesteban
Copy link
Member

oesteban commented Sep 17, 2019

Hey @josephmje this (as in "further PRs") is awaiting nipy/nipype#3034 and nipy/nipype#3031, isn't it?

@josephmje
Copy link
Collaborator Author

@oesteban yes it is. But for now, I've got an fsl.py and mrtrix.py script that contains the interfaces I was using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants