FIX: Coerce license path to pathlike #2180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
reviewed
Jun 7, 2020
| @@ -237,6 +237,7 @@ def __call__(self, parser, namespace, values, option_string=None): | |||
|
|
|||
| def _is_file(path, parser): | |||
| """Ensure a given path exists and it is a file.""" | |||
| path = os.path.abspath(path) | |||
There was a problem hiding this comment.
I would suggest that we switch to return os.path.abspath(path), so that the exception matches the user input.
Feel free to disregard and merge, if you disagree. This is a good fix.
There was a problem hiding this comment.
I'll merge it in as is, I feel the full path to the invalid license would be helpful when debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2165 dropped the conversion from str -> path-like for the wrapper's FreeSurfer license binding