Skip to content

FIX: Pin PyBIDS < 0.11 (and TemplateFlow < 0.6.3) only on the 1.2.x series. #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

oesteban
Copy link
Member

See #548 for the fix in the development branch.

Also, pin templateflow < 0.6.3 for the same reason.
See #548 for the fix in the development branch.
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(pybids): disallow pybids 0.11 as the extension magic breaks tests

Powered by Pull Assistant. Last update 2a30daf ... 2a30daf. Read the comment docs.

@oesteban oesteban added this to the 1.2.7 milestone Aug 12, 2020
@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #552 into maint/1.2.x will increase coverage by 25.93%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           maint/1.2.x     #552       +/-   ##
================================================
+ Coverage        33.87%   59.81%   +25.93%     
================================================
  Files               43       42        -1     
  Lines             5275     5275               
  Branches           768      768               
================================================
+ Hits              1787     3155     +1368     
+ Misses            3465     1991     -1474     
- Partials            23      129      +106     
Flag Coverage Δ
#documentation ?
#reportlettests 100.00% <ø> (?)
#travis 59.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
niworkflows/func/util.py 25.00% <0.00%> (-62.50%) ⬇️
niworkflows/anat/ants.py 12.15% <0.00%> (-57.46%) ⬇️
niworkflows/anat/freesurfer.py 39.13% <0.00%> (-52.18%) ⬇️
niworkflows/anat/skullstrip.py 30.00% <0.00%> (-50.00%) ⬇️
niworkflows/interfaces/fixes.py 41.17% <0.00%> (-5.89%) ⬇️
niworkflows/__init__.py
niworkflows/interfaces/utils.py 37.76% <0.00%> (+2.85%) ⬆️
niworkflows/interfaces/registration.py 51.72% <0.00%> (+3.44%) ⬆️
niworkflows/interfaces/surf.py 47.46% <0.00%> (+7.24%) ⬆️
niworkflows/interfaces/plotting.py 84.74% <0.00%> (+10.16%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0e9d30...2a30daf. Read the comment docs.

@oesteban oesteban merged commit 89efea4 into maint/1.2.x Aug 12, 2020
@effigies effigies deleted the rel/1.2.7 branch August 12, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants