Skip to content

ENH: Toggle requirement for any image type BIDSDataGrabber, add task filtering when collecting PET data #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 6, 2025

Conversation

mnoergaard
Copy link
Contributor

@mnoergaard mnoergaard commented May 26, 2025

Needed to update this part to be able to run PETPrep without the workflow looking for functional data, when not using the --anat-only flag.

Copy link

codecov bot commented Jun 5, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (37a8147) to head (9fd80dc).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
niworkflows/utils/bids.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #951      +/-   ##
==========================================
+ Coverage   71.42%   71.53%   +0.10%     
==========================================
  Files          89       89              
  Lines        8631     8648      +17     
  Branches     1075     1075              
==========================================
+ Hits         6165     6186      +21     
+ Misses       2232     2230       -2     
+ Partials      234      232       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks compatibility with other tools depending on these - rather than this, we should add deviations where necessary.

@mnoergaard
Copy link
Contributor Author

mnoergaard commented Jun 6, 2025

Many thanks to both of you for your feedback. These recent changes seem to work on the petprep side - WDYT?

@mgxd mgxd force-pushed the update_bids_pet branch from 05401a6 to 42cb1a2 Compare June 6, 2025 15:36
@mgxd
Copy link
Contributor

mgxd commented Jun 6, 2025

@mnoergaard I cleaned up the BIDSDataGrabber logic in 42cb1a2 - mainly generalizing require_* to encompass all the image types we support. A few changes of note:

  • renamed require_funcs to require_bold, which is more in-line with the query and the other types.
  • require_pet will not implicitly disable require_bold - they should be controlled separately

mgxd
mgxd previously requested changes Jun 6, 2025
@mgxd mgxd dismissed their stale review June 6, 2025 18:45

updated

Copy link
Contributor

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'll let you test the petprep integration prior to merging 😃

@mnoergaard
Copy link
Contributor Author

Awesome - many thanks, @mgxd ! I will go ahead and test it and get back to you. Currently running things with the updated version from 4 hours ago. So good so far!

@mgxd mgxd changed the title WIP: Update BIDS data grabbing to grab only anatomical and PET data (no fu… ENH: Toggle requirement for any image type BIDSDataGrabber, add task filtering when collecting PET data Jun 6, 2025
@mnoergaard mnoergaard merged commit d118beb into master Jun 6, 2025
35 checks passed
@mnoergaard mnoergaard deleted the update_bids_pet branch June 6, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants