-
Notifications
You must be signed in to change notification settings - Fork 53
ENH: Toggle requirement for any image type BIDSDataGrabber, add task filtering when collecting PET data #951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #951 +/- ##
==========================================
+ Coverage 71.42% 71.53% +0.10%
==========================================
Files 89 89
Lines 8631 8648 +17
Branches 1075 1075
==========================================
+ Hits 6165 6186 +21
+ Misses 2232 2230 -2
+ Partials 234 232 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks compatibility with other tools depending on these - rather than this, we should add deviations where necessary.
Many thanks to both of you for your feedback. These recent changes seem to work on the petprep side - WDYT? |
Co-authored-by: Mathias Goncalves <[email protected]>
@mnoergaard I cleaned up the BIDSDataGrabber logic in 42cb1a2 - mainly generalizing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I'll let you test the petprep integration prior to merging 😃
Awesome - many thanks, @mgxd ! I will go ahead and test it and get back to you. Currently running things with the updated version from 4 hours ago. So good so far! |
Needed to update this part to be able to run PETPrep without the workflow looking for functional data, when not using the --anat-only flag.