Skip to content

Add --no-tty option to smriprep-docker.py #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

kjamison
Copy link
Contributor

Adding an option to the wrapper to omit the "-it" argument to docker, which avoids crashes in non-interactive environments (#209)

@pep8speaks
Copy link

Hello @kjamison! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 328:1: W293 blank line contains whitespace

@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     Add --no-tty option to smriprep-docker.py

Powered by Pull Assistant. Last update 3d50141 ... 3d50141. Read the comment docs.

@effigies
Copy link
Member

Looks reasonable. If nobody has any objection, I'll merge tomorrow.

Would you mind making a similar PR on fMRIPrep?

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #216 into master will decrease coverage by 44.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #216       +/-   ##
===========================================
- Coverage   71.59%   26.64%   -44.96%     
===========================================
  Files          16       16               
  Lines        1021     1021               
  Branches      142      142               
===========================================
- Hits          731      272      -459     
- Misses        240      736      +496     
+ Partials       50       13       -37     
Flag Coverage Δ
#ds005 ?
#ds054 ?
Impacted Files Coverage Δ
smriprep/cli/run.py 2.87% <0.00%> (-74.17%) ⬇️
smriprep/workflows/norm.py 30.76% <0.00%> (-69.24%) ⬇️
smriprep/__main__.py 16.66% <0.00%> (-66.67%) ⬇️
smriprep/workflows/surfaces.py 14.60% <0.00%> (-64.05%) ⬇️
smriprep/workflows/outputs.py 14.28% <0.00%> (-57.15%) ⬇️
smriprep/workflows/anatomical.py 16.99% <0.00%> (-51.64%) ⬇️
smriprep/workflows/base.py 30.00% <0.00%> (-50.00%) ⬇️
smriprep/interfaces/freesurfer.py 19.69% <0.00%> (-40.91%) ⬇️
smriprep/interfaces/reports.py 54.43% <0.00%> (-22.79%) ⬇️
smriprep/utils/bids.py 42.50% <0.00%> (-1.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d340d17...3d50141. Read the comment docs.

@mgxd
Copy link
Collaborator

mgxd commented Jul 9, 2020

Thanks again @kjamison

@mgxd mgxd merged commit ad75bc9 into nipreps:master Jul 9, 2020
@effigies
Copy link
Member

effigies commented Jul 9, 2020

Woops, failed to merge as I said. Thanks @mgxd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants