-
Notifications
You must be signed in to change notification settings - Fork 532
MNT: Drop Python 2 support #2654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 17 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
1108430
CI: Drop Python 2 tests
effigies 4a84a02
RF: Remove builtins
effigies 9e47ec0
RF: Drop one-line __future__ imports
effigies 06ecbe4
RF: Remove two-line __future__ imports
effigies b90f7d5
MAINT: Update version, supported Python versions
effigies b5ef915
FIX: Dangling import
effigies e968b8d
RF: Drop imports in checkspecs
effigies 7a0e638
MAINT: make specs
effigies fa347ae
CI: Drop 2.7, add 3.7-dev on Travis
effigies f25cfc0
RF: Purge PY2/PY3 indicators
effigies 323663f
RF: Purge "from io import open"
effigies e2dc9f8
DOC: Suggest raise from syntax
effigies 9517c5a
TEST: Drop legacy auto tests
effigies f4f7865
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 421600b
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 1e5344e
CI: Build Python 3 wheels only
effigies 055a59f
FIX: Run decode on bytes, not tuple
effigies 938cdf4
CI: Do not install future, remove futures check
effigies f31416a
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies e990c69
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 2cfcd5a
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies dbfaf7e
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 9880669
Merge branch 'master' into dev/2.0
effigies 83e4dc9
PY3: Drop future/builtins imports
effigies e057971
MAINT: Minimum python version > 3.2
effigies b0d464c
RF: Drop various remaining compatibilities for Python < 3.5
effigies be2d8c5
RF: Drop to_str, makedirs compatibility functions
effigies 5ab2fa0
FIX: import os - mistakenly dropped
effigies dc89681
FIX: os.makedirs does not return directory
effigies 80ed64d
Merge pull request #2831 from effigies/dev/2/min_version
effigies f112c58
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies d997694
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 375d00f
Merge branch 'master' into dev/2.0
effigies 08cd3d3
MAINT: Sort dependencies
effigies f464954
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 7baa6d3
PY3: Remove PY2 str hack
effigies 797841b
Merge branch 'master' into dev/2.0
effigies 72ac8a5
MNT: Missed Py2 cleanups
effigies 7b9c639
MNT: Drop Py2 compatibility for tools/
effigies 497b44d
STY: Black files pre-merge
effigies 49cc0a7
Merge remote-tracking branch 'upstream/master' into dev/2.0
effigies 39fbd54
FIX: Missed merge issue
effigies File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,20 +56,6 @@ _build_main_image_py36: &build_main_image_py36 | |
--build-arg VCS_REF="$(git rev-parse --short HEAD)" \ | ||
--build-arg VERSION="${CIRCLE_TAG}" /home/circleci/nipype | ||
|
||
_build_main_image_py27: &build_main_image_py27 | ||
name: Build main image (py27) | ||
no_output_timeout: 60m | ||
command: | | ||
tools/retry_cmd.sh -n 5 -s 15 \ | ||
docker build \ | ||
--rm=false \ | ||
--tag nipype/nipype:py27 \ | ||
--build-arg PYTHON_VERSION_MAJOR=2 \ | ||
--build-arg PYTHON_VERSION_MINOR=7 \ | ||
--build-arg BUILD_DATE="$(date -u +"%Y-%m-%dT%H:%M:%SZ")" \ | ||
--build-arg VCS_REF="$(git rev-parse --short HEAD)" \ | ||
--build-arg VERSION="${CIRCLE_TAG}-py27" /home/circleci/nipype | ||
|
||
_download_test_data: &_download_test_data | ||
name: Download test data | ||
no_output_timeout: 20m | ||
|
@@ -161,28 +147,22 @@ jobs: | |
- run: *modify_nipype_version | ||
- run: *get_base_image | ||
- run: *build_main_image_py36 | ||
- run: *build_main_image_py27 | ||
- run: *_get_codecov | ||
- run: *_download_test_data | ||
- run: *prepare_working_directory | ||
- run: | ||
name: Run pytests (py36) | ||
name: Run pytests | ||
no_output_timeout: 30m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_pytest.sh | ||
- run: | ||
name: Run pytests (py27) | ||
no_output_timeout: 30m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py2_pytest.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_pytest.sh | ||
- run: *_run_codecov_coverage | ||
- store_artifacts: *store_artifacts_kwds | ||
- store_test_results: *store_artifacts_kwds | ||
- run: | ||
name: Build docs (py36) | ||
name: Build docs | ||
no_output_timeout: 30m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_docs.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/build_docs.sh | ||
- store_artifacts: | ||
path: /home/circleci/work/docs | ||
- run: | ||
|
@@ -192,16 +172,15 @@ jobs: | |
if [ "$CIRCLE_BRANCH" = "master" -a -z "$CIRCLE_PULL_REQUEST" ]; then | ||
docker save nipype/nipype:base \ | ||
nipype/nipype:latest \ | ||
nipype/nipype:py27 \ | ||
nipype/nipype:py36 | gzip -1 > /tmp/docker/nipype-base-latest-py36-py27.tar.gz \ | ||
&& du -h /tmp/docker/nipype-base-latest-py36-py27.tar.gz | ||
nipype/nipype:py36 | gzip -1 > /tmp/docker/nipype-base-latest-py36.tar.gz \ | ||
&& du -h /tmp/docker/nipype-base-latest-py36.tar.gz | ||
fi | ||
- persist_to_workspace: | ||
root: /tmp | ||
paths: | ||
- docker | ||
|
||
test_py3_fmri_fsl_spm: | ||
test_fmri_fsl_spm: | ||
machine: *machine_kwds | ||
working_directory: /home/circleci/nipype | ||
steps: | ||
|
@@ -218,24 +197,24 @@ jobs: | |
- run: *_download_test_data | ||
- run: *prepare_working_directory | ||
- run: | ||
name: Run FSL reuse pipeline (py36) | ||
name: Run FSL reuse pipeline | ||
no_output_timeout: 40m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_fsl_reuse_linear_l1.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_fsl_reuse_linear_l1.sh | ||
- run: | ||
name: Run SPM test workflow - 3D inputs (py36) | ||
name: Run SPM test workflow - 3D inputs | ||
no_output_timeout: 40m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_spm_linear_3d.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_linear_3d.sh | ||
- run: | ||
name: Run SPM test workflow - 4D inputs (py36) | ||
name: Run SPM test workflow - 4D inputs | ||
no_output_timeout: 40m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_spm_linear_4d.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_linear_4d.sh | ||
- run: *_run_codecov_smoke | ||
- store_artifacts: *store_artifacts_kwds | ||
|
||
test_py3_fmri_spm_dartel_multiproc: | ||
test_fmri_spm_dartel_multiproc: | ||
machine: *machine_kwds | ||
working_directory: /home/circleci/nipype | ||
steps: | ||
|
@@ -252,15 +231,15 @@ jobs: | |
- run: *_download_test_data | ||
- run: *prepare_working_directory | ||
- run: | ||
name: Run SPM DARTEL Level 1 pipeline (py36) | ||
name: Run SPM DARTEL Level 1 pipeline | ||
no_output_timeout: 1h | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_spm_dartel_multiproc_l1.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_dartel_multiproc_l1.sh | ||
- run: | ||
name: Run SPM DARTEL Level 2 pipeline (py36) | ||
name: Run SPM DARTEL Level 2 pipeline | ||
no_output_timeout: 30m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_spm_dartel_multiproc_l2.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_dartel_multiproc_l2.sh | ||
- run: *_run_codecov_smoke | ||
- store_artifacts: *store_artifacts_kwds | ||
|
||
|
@@ -277,25 +256,24 @@ jobs: | |
- run: *modify_nipype_version | ||
- run: *get_base_image | ||
- run: *build_main_image_py36 | ||
- run: *build_main_image_py27 | ||
- run: *_get_codecov | ||
- run: *_download_test_data | ||
- run: *prepare_working_directory | ||
- run: | ||
name: Run SPM Nested Level 1 pipeline (py36) | ||
name: Run SPM Nested Level 1 pipeline | ||
no_output_timeout: 1h | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_spm_nested_multiproc_l1.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_nested_multiproc_l1.sh | ||
- run: | ||
name: Run SPM Nested Level 2 pipeline (py27) | ||
name: Run SPM Nested Level 2 pipeline | ||
no_output_timeout: 30m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py2_fmri_spm_nested_multiproc_l2.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_spm_nested_multiproc_l2.sh | ||
- run: | ||
name: Run FSL FEEDS pipeline (py36) | ||
name: Run FSL FEEDS pipeline | ||
no_output_timeout: 40m | ||
environment: *test_environment | ||
command: bash -ux /home/circleci/nipype/.circleci/test_py3_fmri_fsl_feeds_linear_l1.sh | ||
command: bash -ux /home/circleci/nipype/.circleci/test_fmri_fsl_feeds_linear_l1.sh | ||
- run: *_run_codecov_smoke | ||
- store_artifacts: *store_artifacts_kwds | ||
|
||
|
@@ -310,7 +288,7 @@ jobs: | |
name: Load saved Docker images. | ||
no_output_timeout: 60m | ||
command: | | ||
docker load < /tmp/docker/nipype-base-latest-py36-py27.tar.gz | ||
docker load < /tmp/docker/nipype-base-latest-py36.tar.gz | ||
- run: | ||
name: Push to DockerHub | ||
no_output_timeout: 120m | ||
|
@@ -319,7 +297,6 @@ jobs: | |
docker push nipype/nipype:base | ||
docker push nipype/nipype:latest | ||
docker push nipype/nipype:py36 | ||
docker push nipype/nipype:py27 | ||
- run: | ||
name: Move pruned Dockerfile to /tmp/docker/cache directory | ||
command: | | ||
|
@@ -339,21 +316,15 @@ jobs: | |
- run: | ||
name: Check pypi preconditions | ||
command: | | ||
pyenv local 3.5.2 | ||
pip install --upgrade twine future wheel readme_renderer setuptools | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't we remove |
||
python setup.py check -r -s | ||
python setup.py sdist bdist_wheel | ||
- run: | ||
name: Validate Python 2 installation | ||
command: | | ||
pyenv local 2.7.12 | ||
pip install dist/nipype-*-py2.py3-none-any.whl | ||
# Futures should install in Python 2 | ||
pip show futures 2>/dev/null | grep "Name: futures" | ||
- run: | ||
name: Validate Python 3 installation | ||
command: | | ||
pyenv local 3.5.2 | ||
pip install dist/nipype-*-py2.py3-none-any.whl | ||
pip install dist/nipype-*-py3-none-any.whl | ||
# Futures should not install in Python 3 | ||
test $(pip show futures 2>/dev/null | wc -l) = "0" | ||
- store_artifacts: | ||
|
@@ -368,6 +339,7 @@ jobs: | |
- run: | ||
name: Deploy to PyPI | ||
command: | | ||
pyenv local 3.5.2 | ||
pip install --upgrade twine future wheel readme_renderer setuptools | ||
python setup.py check -r -s | ||
python setup.py sdist bdist_wheel | ||
|
@@ -412,7 +384,7 @@ workflows: | |
- pypi_precheck: | ||
filters: | ||
branches: | ||
only: /rel\/.*/ | ||
only: /(rel|dev)\/.*/ | ||
tags: | ||
only: /.*/ | ||
- compare_base_dockerfiles: | ||
|
@@ -425,10 +397,10 @@ workflows: | |
only: /.*/ | ||
requires: | ||
- compare_base_dockerfiles | ||
- test_py3_fmri_fsl_spm: | ||
- test_fmri_fsl_spm: | ||
requires: | ||
- compare_base_dockerfiles | ||
- test_py3_fmri_spm_dartel_multiproc: | ||
- test_fmri_spm_dartel_multiproc: | ||
requires: | ||
- compare_base_dockerfiles | ||
- test_fmri_spm_nested_fsl_feeds: | ||
|
@@ -441,8 +413,8 @@ workflows: | |
requires: | ||
- test_pytest | ||
- test_fmri_spm_nested_fsl_feeds | ||
- test_py3_fmri_fsl_spm | ||
- test_py3_fmri_spm_dartel_multiproc | ||
- test_fmri_fsl_spm | ||
- test_fmri_spm_dartel_multiproc | ||
- deploy_pypi: | ||
filters: | ||
branches: | ||
|
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
.../test_py2_fmri_spm_nested_multiproc_l2.sh → ...leci/test_fmri_spm_nested_multiproc_l2.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
#!/bin/bash | ||
|
||
docker run --rm=false -t -v $WORKDIR:/work -v $HOME/examples:/data/examples:ro -w /work -e NIPYPE_NUMBER_OF_CPUS=4 -e NIPYPE_RESOURCE_MONITOR=1 "${DOCKER_IMAGE}:py27" /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ l2pipeline | ||
docker run --rm=false -t -v $WORKDIR:/work -v $HOME/examples:/data/examples:ro -w /work -e NIPYPE_NUMBER_OF_CPUS=4 -e NIPYPE_RESOURCE_MONITOR=1 "${DOCKER_IMAGE}:py36" /usr/bin/run_examples.sh fmri_spm_nested MultiProc /data/examples/ l2pipeline |
This file was deleted.
Oops, something went wrong.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we consider breaking off the workflows and workflow tests to niflows, before we break off 2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm also fine with making all the breaks with 2.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to start moving things to niflows. Have we figured out a working plan for that? Maybe could do a chat sometime this week to iron out a rough plan?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll coordinate a time.