tst: use pytest fixture #3059
Merged
tst: use pytest fixture #3059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we retry, to improve the odds of completion? If it's really hit-or-miss, this is likely to be a constant source of noise in coverage reports. |
effigies
reviewed
Oct 2, 2019
| return data | ||
| @pytest.fixture | ||
| def fetch_data(): | ||
| def _fetch_data(datadir, dicoms): |
There was a problem hiding this comment.
Suggested change
| def _fetch_data(datadir, dicoms): | |
| def _fetch_data(datadir, dicoms, retry=3): |
| data = os.path.join(datadir, dicoms) | ||
| api.get(path=data) | ||
| except IncompleteResultsError as exc: | ||
| pytest.skip("Failed to fetch test data: %s" % str(exc)) |
There was a problem hiding this comment.
Suggested change
| pytest.skip("Failed to fetch test data: %s" % str(exc)) | |
| if retry: | |
| return _fetch_data(datadir, dicoms, retry=retry-1) | |
| pytest.skip("Failed to fetch test data: %s" % str(exc)) |
|
Merging. If the codecov thing becomes an issue, we can add in the retry, but the stochastic failures are a bigger problem right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying again after #3058 - otherwise we should xfail it for the time being.
Acknowledgment