Skip to content

MNT: Drop Python 3.4 support #3062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2019
Merged

MNT: Drop Python 3.4 support #3062

merged 2 commits into from
Oct 7, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 3, 2019

Summary

This PR does not attempt to hunt down Python 3.4-isms and purge them. Just removes the test battery and updates the package metadata.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #3062 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3062      +/-   ##
==========================================
- Coverage   67.72%   67.67%   -0.05%     
==========================================
  Files         344      344              
  Lines       44087    44087              
  Branches     5554     5554              
==========================================
- Hits        29856    29836      -20     
- Misses      13465    13485      +20     
  Partials      766      766
Flag Coverage Δ
#smoketests 50.29% <100%> (ø) ⬆️
#unittests 65.13% <100%> (-0.05%) ⬇️
Impacted Files Coverage Δ
nipype/info.py 94.36% <100%> (ø) ⬆️
nipype/interfaces/dcm2nii.py 59.06% <0%> (-6.05%) ⬇️
nipype/utils/filemanip.py 78.97% <0%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085767c...aadc37a. Read the comment docs.

@effigies effigies added this to the 1.3.0 milestone Oct 3, 2019
@effigies effigies merged commit 1ccd70b into nipy:master Oct 7, 2019
@effigies effigies deleted the mnt/drop_34 branch October 7, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant