Skip to content

enh: add precommit information for contributors and pre-commit style #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 8, 2019

Conversation

satra
Copy link
Member

@satra satra commented Oct 4, 2019

List of changes proposed in this PR (pull-request)

Add pre-commit config and developer information

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@7d310dd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3063   +/-   ##
=========================================
  Coverage          ?   67.69%           
=========================================
  Files             ?      344           
  Lines             ?    44127           
  Branches          ?     5564           
=========================================
  Hits              ?    29870           
  Misses            ?    13491           
  Partials          ?      766
Flag Coverage Δ
#smoketests 50.31% <ø> (?)
#unittests 65.1% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d310dd...344c6ba. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One typo.

Co-Authored-By: Chris Markiewicz <[email protected]>
@effigies effigies added this to the 1.3.0 milestone Oct 7, 2019
@effigies effigies mentioned this pull request Oct 8, 2019
13 tasks
@effigies effigies merged commit f0a01b5 into nipy:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants