Skip to content

CI: make check-before-commit on Travis #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 8, 2019
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 7, 2019

Summary

Adds a make check-before-commit test to Travis, to verify that no changes are made to the working directory. This will help catch situations where people fail to run make specs, but it doesn't cause an error (e.g., adding an input) and when a test pollutes the repository with what should be temporary files.

Closes #2967.

List of changes proposed in this PR (pull-request)

  • New Travis test
  • Some cleanups from running locally, including a bunch of warnings about regexes

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies added this to the 1.3.0 milestone Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #3066 into master will increase coverage by <.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3066      +/-   ##
==========================================
+ Coverage    67.7%   67.71%   +<.01%     
==========================================
  Files         344      344              
  Lines       44112    44165      +53     
  Branches     5563     5585      +22     
==========================================
+ Hits        29866    29905      +39     
- Misses      13481    13489       +8     
- Partials      765      771       +6
Flag Coverage Δ
#smoketests 50.31% <0%> (ø) ⬆️
#unittests 65.13% <25%> (+0.01%) ⬆️
Impacted Files Coverage Δ
nipype/interfaces/fsl/utils.py 70.35% <ø> (ø) ⬆️
nipype/interfaces/io.py 59.26% <ø> (ø) ⬆️
nipype/interfaces/utility/base.py 87.5% <ø> (ø) ⬆️
nipype/interfaces/image.py 73.41% <ø> (ø) ⬆️
nipype/interfaces/afni/utils.py 81.89% <0%> (ø) ⬆️
nipype/interfaces/diffusion_toolkit/dti.py 63.88% <0%> (ø) ⬆️
nipype/interfaces/dipy/tracks.py 31.11% <0%> (-0.56%) ⬇️
nipype/pipeline/engine/utils.py 80.76% <100%> (ø) ⬆️
nipype/pipeline/plugins/multiproc.py 81.39% <0%> (-3.18%) ⬇️
nipype/__init__.py 65.07% <0%> (+3.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ccd70b...2514026. Read the comment docs.

Copy link
Contributor

@oesteban oesteban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left just a minimal suggestion to only run the specs.

Co-Authored-By: Oscar Esteban <[email protected]>
@effigies effigies mentioned this pull request Oct 8, 2019
13 tasks
@effigies effigies merged commit 9e19349 into nipy:master Oct 8, 2019
@effigies effigies deleted the ci/make_checks branch October 8, 2019 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run make specs on Circle/Travis
2 participants