-
Notifications
You must be signed in to change notification settings - Fork 532
CI: make check-before-commit on Travis #3066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3066 +/- ##
==========================================
+ Coverage 67.7% 67.71% +<.01%
==========================================
Files 344 344
Lines 44112 44165 +53
Branches 5563 5585 +22
==========================================
+ Hits 29866 29905 +39
- Misses 13481 13489 +8
- Partials 765 771 +6
Continue to review full report at Codecov.
|
f00cc46
to
f56a286
Compare
f56a286
to
2174a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left just a minimal suggestion to only run the specs.
Co-Authored-By: Oscar Esteban <[email protected]>
Summary
Adds a
make check-before-commit
test to Travis, to verify that no changes are made to the working directory. This will help catch situations where people fail to runmake specs
, but it doesn't cause an error (e.g., adding an input) and when a test pollutes the repository with what should be temporary files.Closes #2967.
List of changes proposed in this PR (pull-request)
Acknowledgment