ENH: Detect values for EulerNumber interface #3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3173 +/- ##
=======================================
Coverage 64.03% 64.03%
=======================================
Files 297 297
Lines 39422 39422
Branches 5210 5210
=======================================
Hits 25244 25244
Misses 13138 13138
Partials 1040 1040
Continue to review full report at Codecov.
|
|
LGTM. Maybe add a test to make sure it reports that |
mgxd
force-pushed
the
enh/euler-number
branch
from
58091aa to
312ae3d
Compare
|
Codecov seems borked, but tests are passing. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes proposed in this PR (pull-request)
Parse
freesurfer.utils.EulerNumberoutput to autodetect values. Currently,mris_euler_numbervalues are written to stderr, but this may not be intended, so we should prioritize stdout.Remove unused
out_fileoutput.(Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.