ENH: Add "TruncateImageIntensity" operation to ants.utils.Image.Math
#3210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Math`` ``"TruncateImageIntensity"`` is part of ``antsBrainExtraction.sh`` and therefore, having it supported by nipype is of great interest. This PR addresses a problem @eilidhmacnicol just discovered. Having this merged will also allow us to call the upstreaming of ANTS interfaces from niworkflows done.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Apr 27, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
Codecov Report
@@ Coverage Diff @@
## master #3210 +/- ##
=======================================
Coverage 65.01% 65.01%
=======================================
Files 301 301
Lines 39834 39834
Branches 5269 5269
=======================================
Hits 25897 25897
Misses 12880 12880
Partials 1057 1057
Continue to review full report at Codecov.
|
|
Any voices against merging this super-low risk change? |
|
Nope, this is fine with me. |
|
But do we need to make specs? |
|
|
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 4, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 4, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 5, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 9, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 12, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
oesteban
added a commit
to oesteban/niworkflows
that referenced
this pull request
Jun 26, 2020
After nipy/nipype#3210 the ``niworkflows/interfaces/ants.py`` can go in whole.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"TruncateImageIntensity"is part ofantsBrainExtraction.shand therefore, having it supported by nipype is of great interest.This PR addresses a problem @eilidhmacnicol just discovered. Having this merged will also allow us to call the upstreaming of ANTS interfaces from niworkflows done.
Summary
Fixes # .
List of changes proposed in this PR (pull-request)
Acknowledgment