FIX: Permit identity transforms in list of transforms given to ants.ApplyTransforms #3237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effigies
changed the title
effigies
force-pushed
the
fix/applytransforms_identity
branch
from
2310ecc to
e30d780
Compare
oesteban
approved these changes
Aug 14, 2020
| InputMultiPath(File(exists=True)), | ||
| "identity", | ||
| transforms = InputMultiObject( | ||
| traits.Either(File(exists=True), "identity"), |
There was a problem hiding this comment.
In the latest releases of traits they are recommending Union instead of Either. I don't know when Union started to be available or when they started to recommend it though. I'm just writing this down and don't think it requires any particular action in this PR (cc @satra)
…nsforms Convert to InputMultiObject while we're at it.
effigies
force-pushed
the
fix/applytransforms_identity
branch
from
e30d780 to
c729c1c
Compare
Codecov Report
@@ Coverage Diff @@
## maint/1.5.x #3237 +/- ##
===============================================
+ Coverage 64.96% 65.00% +0.03%
===============================================
Files 302 302
Lines 39942 39942
Branches 5282 5282
===============================================
+ Hits 25949 25964 +15
+ Misses 12927 12918 -9
+ Partials 1066 1060 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Okay, tests passing. Thanks for having a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
antsApplyTransforms currently permits
identityor a chain of transformations, but it can be useful to insert anidentityinto a chain.List of changes proposed in this PR (pull-request)
Either(InputMultiObject(File), "identity")toInputMultiObject(Either(File, "identity")).InputMultiPathtoInputMultiObjectthroughout the file, in passing.--transformarguments.Acknowledgment