Skip to content

FIX: Serialize all interface arguments when exporting workflows #3240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 16, 2020

Conversation

effigies
Copy link
Member

Summary

@matteomancini Apologies for taking over your PR. I had some maintenance changes to make, and ended up making more significant changes than I felt comfortable force-pushing to your branch. Feel free to take these changes to your PR, if you have further changes you want to make. I would also appreciate your review.

Fixes #3230.
Closes #3231.

List of changes proposed in this PR (pull-request)

#3231 Ensured that values passed to nodes would be reproduced after being serialized. This PR:

  1. Added a test to verify that the problem was demonstrated and the solution resolved it. (It did.)
  2. Rebased against maint/1.5.x so that this can go in the next release.
  3. Decided to use f-strings and the repr (!r) format to avoid branching, then saw opportunities to further refactor.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #3240 into maint/1.5.x will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.5.x    #3240      +/-   ##
===============================================
+ Coverage        65.00%   65.03%   +0.02%     
===============================================
  Files              302      302              
  Lines            39942    39939       -3     
  Branches          5282     5280       -2     
===============================================
+ Hits             25964    25974      +10     
+ Misses           12918    12895      -23     
- Partials          1060     1070      +10     
Flag Coverage Δ
#unittests 65.03% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/pipeline/engine/utils.py 74.48% <100.00%> (+2.87%) ⬆️
nipype/pipeline/plugins/legacymultiproc.py 65.68% <0.00%> (-3.44%) ⬇️
nipype/pipeline/plugins/base.py 58.08% <0.00%> (-1.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f90dd...fc8e991. Read the comment docs.

@effigies effigies added this to the 1.5.1 milestone Aug 15, 2020
@effigies effigies changed the title FIX: Correctly serialize nodes when exporting workflows FIX: Serialize all interface arguments when exporting workflows Aug 15, 2020
@effigies effigies merged commit d7a775b into nipy:maint/1.5.x Aug 16, 2020
@effigies effigies deleted the fix/export_workflow branch August 16, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants