Skip to content

ENH: json-related entities in MRConvert's inputs specification #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

ENH: json-related entities in MRConvert's inputs specification #3401

wants to merge 5 commits into from

Conversation

GalKepler
Copy link
Contributor

@GalKepler GalKepler commented Oct 30, 2021

Summary

Fixes #3400 - jsons' import and export are now available under "json_import" and "json_export" optional inputs respectively.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #3401 (480c1f9) into master (ae1e033) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3401      +/-   ##
==========================================
- Coverage   65.21%   65.21%   -0.01%     
==========================================
  Files         307      307              
  Lines       40474    40479       +5     
  Branches     5351     5352       +1     
==========================================
+ Hits        26395    26398       +3     
- Misses      13004    13006       +2     
  Partials     1075     1075              
Flag Coverage Δ
unittests 64.94% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/mrtrix/convert.py 17.18% <0.00%> (ø)
nipype/interfaces/mrtrix3/utils.py 82.46% <60.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae1e033...480c1f9. Read the comment docs.

@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
@GalKepler GalKepler deleted the mrconvert branch May 13, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MRConvert missing json-related keyword arguments' interfaces
2 participants