Skip to content

[ENH] Enable BidsDataGrabber to load saved layouts #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2022

Conversation

pakux
Copy link
Contributor

@pakux pakux commented Dec 10, 2021

A new input load_layout enables the BIDSDataGrabber to read a previously saved BIDSLayout. This makes the use of BidsDatagrabber much faster, since it doesn't need to reinterpret all Bidsfiles every time.

Layouts can be saved via layout.save(<path>).

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #3421 (281b236) into master (e31573b) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #3421      +/-   ##
==========================================
- Coverage   65.21%   65.21%   -0.01%     
==========================================
  Files         308      308              
  Lines       40530    40533       +3     
  Branches     5353     5354       +1     
==========================================
+ Hits        26433    26434       +1     
- Misses      13021    13023       +2     
  Partials     1076     1076              
Flag Coverage Δ
unittests 64.94% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/io.py 55.19% <25.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31573b...281b236. Read the comment docs.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge on passing tests.

@effigies effigies merged commit 256d289 into nipy:master Apr 2, 2022
@effigies effigies added this to the 1.7.1 milestone Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants