Bugfix: a namespace in the inclusive namespace list should be treated… #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as if it were handled by the non-exclusive algorithm and thus written out on the root note of the canonical document.
LoneRifle
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… where non-exclusive and thus written out on the root note of the canonical document.
According to the WC3 specification, namespaces in the inclusive namespace list should be treated as if by the exclusive algorithm. For a document subset, the exclusive algorithm copies namespaces from ancestor nodes to the root of the document in canonical from (see https://www.w3.org/TR/xml-c14n11/#Example-DocSubsets)
This patch ensures that such ancestor namespaces are treated correctly as well as adding a test for this behavior.