Skip to content

Fix test case error #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix test case error #338

merged 1 commit into from
Jul 13, 2023

Conversation

git9527
Copy link
Contributor

@git9527 git9527 commented Jul 13, 2023

No description provided.

@cjbarth cjbarth changed the title fix test case error Fix test case error Jul 13, 2023
@cjbarth cjbarth added the bug label Jul 13, 2023
@cjbarth cjbarth merged commit a259d83 into node-saml:3.x Jul 13, 2023
@cjbarth
Copy link
Contributor

cjbarth commented Jul 13, 2023

Thank you for that. It fixed some of the errors, but now there are others preventing the 3.x release. Would you be in a position to have a look?

If you checkout the head of the 3.x branch and run npm ci && npm test, you'll see that a single test is failing: signer adds increasing id attributes to elements

@git9527
Copy link
Contributor Author

git9527 commented Jul 14, 2023

sorry, I can't reproduce the failure in my local. All cases passed.
image

@cjbarth
Copy link
Contributor

cjbarth commented Jul 14, 2023

Nevermind. I've worked past this and am preparing a release. I should have it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants