-
Notifications
You must be signed in to change notification settings - Fork 12
feat(perf): use @minify-html
#331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 71.51% 71.52% +0.01%
==========================================
Files 117 117
Lines 9721 9719 -2
Branches 590 590
==========================================
Hits 6952 6952
+ Misses 2766 2764 -2
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also, Shiki is defining a --shiki-dark CSS variable, which I don't think we use, is that disable-able? |
Does it matter? |
Yes, it'll drastically reduce our output size if it wasn't defined, since EACH code block contains a variable definition. |
Check Shiki docs, it might be doable. |
Ahhh nevermind we do use them in html.dark-mode .shiki,
html.dark-mode .shiki span {
color: var(--shiki-dark) !important;
background-color: var(--shiki-dark-bg) !important;
/* Optional, if you also want font styles */
font-style: var(--shiki-dark-font-style) !important;
font-weight: var(--shiki-dark-font-weight) !important;
text-decoration: var(--shiki-dark-text-decoration) !important;
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you was quicker thank me 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
I'm fast-tracking this as this is pretty much just a dependency change and I doubt anyone will have anything against this. (And to unblock the web generator) |
Fixes #330
See #330 (comment) for the size difference, and see #330 (comment) for the rationale.
TL;DR This minifier is faster, and outputs smaller bundles