Review state of canary in CI

[targos]

Commit: ae3407f

node-test-commit: https://ci.nodejs.org/job/node-test-commit/53135/
node-test-commit-v8-linux: https://ci.nodejs.org/job/node-test-commit-v8-linux/4652/

[richardlau]

@targos FYI we'd need to add ICU 71 (the new minimum) to the sharedlib containers for the CI dynamically linked ICU builds to pass.

[targos]

@richardlau that would be in https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu2004_sharedlibs.Dockerfile.j2 ? I can try to make a PR.

[richardlau]

@targos we're actually still using https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1804_sharedlibs.Dockerfile.j2 but yeah we should probably start moving the sharedlib testing onto Ubuntu 20.04 (or jump to 22.04). We could also remove ICU 64 from the containers once Node.js 12 goes EOL.

[richardlau]

Resumed CI: https://ci.nodejs.org/job/node-test-commit/53143/

[targos]

I don't get the Windows debug failure (https://ci.nodejs.org/job/node-compile-windows-debug/11712/nodes=win-vs2019/console).
It seems to fail building an addon test (binding is missing), but there's no output from the node-gyp execution:

19:36:14 > "Debug\node.exe" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory=test\addons\hello-world --nodedir="C:\workspace\node-compile-windows-debug\node" 
19:36:14 
19:36:14 > if errorlevel 1 exit /b 
19:36:14 
19:36:14 > Debug\node.exe test\addons\hello-world\test.js 
19:36:14 node:internal/modules/cjs/loader:942
19:36:15   throw err;
19:36:15   ^
19:36:15 
19:36:15 Error: Cannot find module './build/Debug/binding'
19:36:15 Require stack:
19:36:15 - C:\workspace\node-compile-windows-debug\node\test\addons\hello-world\test.js
19:36:15     at Module._resolveFilename (node:internal/modules/cjs/loader:939:15)
19:36:15     at Function.resolve (node:internal/modules/cjs/helpers:108:19)
19:36:15     at Object.<anonymous> (C:\workspace\node-compile-windows-debug\node\test\addons\hello-world\test.js:4:29)
19:36:15     at Module._compile (node:internal/modules/cjs/loader:1105:14)
19:36:15     at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
19:36:15     at Module.load (node:internal/modules/cjs/loader:981:32)
19:36:15     at Module._load (node:internal/modules/cjs/loader:827:12)
19:36:15     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
19:36:15     at node:internal/main/run_main_module:17:47 {
19:36:15   code: 'MODULE_NOT_FOUND',
19:36:15   requireStack: [
19:36:15     'C:\\workspace\\node-compile-windows-debug\\node\\test\\addons\\hello-world\\test.js'
19:36:15   ]
19:36:15 }
19:36:15 
19:36:15 Node.js v19.0.0-pre

[targos]

New run with 0a262a7

CI: https://ci.nodejs.org/job/node-test-commit/53237/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4657/

[targos]

On my PC:

> .\out\Debug\node.exe .\tools\build-addons.js .\deps\npm\node_modules\node-gyp\bin\node-gyp.js .\test\addons
Building addon in test\addons\async-cleanup-hook
Building addon in test\addons\async-hooks-id
Building addon in test\addons\async-hello-world
Building addon in test\addons\async-resource
Building addon in test\addons\buffer-free-callback
Building addon in test\addons\callback-scope
Building addon in test\addons\dlopen-ping-pong
Building addon in test\addons\errno-exception
Building addon in test\addons\force-context-aware
Building addon in test\addons\heap-profiler
Building addon in test\addons\hello-world
Building addon in test\addons\hello-world-function-export
D:\Git\nodejs\node-v8\tools\build-addons.js:58
main(process.argv[3]).catch((err) => setImmediate(() => { throw err; }));
                                                          ^

Error: Command failed: D:\Git\nodejs\node-v8\out\Debug\node.exe .\deps\npm\node_modules\node-gyp\bin\node-gyp.js rebuild --directory=test\addons\async-hooks-id

    at ChildProcess.exithandler (node:child_process:387:12)
    at ChildProcess.emit (node:events:527:28)
    at maybeClose (node:internal/child_process:1090:16)
    at ChildProcess._handle.onexit (node:internal/child_process:302:5) {
  code: 3221225477,
  killed: false,
  signal: null,
  cmd: 'D:\\Git\\nodejs\\node-v8\\out\\Debug\\node.exe .\\deps\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js rebuild --directory=test\\addons\\async-hooks-id',
  stdout: '',
  stderr: ''
}

Node.js v19.0.0-pre

[targos]

Here's the stack. It's the first time I use Visual Studio's debugger, so I hope I did it right:

[targos]

I commented on the V8 issue related to TurboShaft: https://bugs.chromium.org/p/v8/issues/detail?id=12783#c2

[targos]

New run with 99be974

CI: https://ci.nodejs.org/job/node-test-commit/53477/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4675/

[targos]

New run with beccf54

CI: https://ci.nodejs.org/job/node-test-commit/54192/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4734/

Edit: canary branch was just updated...