Skip to content

test_runner: lcov in node:test/reporters is exported as a value #52385

Closed
@yume-chan

Description

@yume-chan

Version

v20.12.1

Platform

Microsoft Windows NT 10.0.26040.0 x64

Subsystem

No response

What steps will reproduce the bug?

import { lcov } from 'node:test/reporters'

const reporter = lcov()

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

lcov is a function which creates a new reporter, like all other exports in node:test/reporters (spec, dot, junit and tap)

What do you see instead?

lcov is an instance of LcovReporter class.

I think it's a typo at

lcov: {
__proto__: null,
configurable: true,
enumerable: true,
get() {
lcov ??= require('internal/test_runner/reporter/lcov');
return ReflectConstruct(lcov, arguments);
},
},

It should be defined as value, same as spec:

spec: {
__proto__: null,
configurable: true,
enumerable: true,
value: function value() {
spec ??= require('internal/test_runner/reporter/spec');
return ReflectConstruct(spec, arguments);
},
},

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    test_runnerIssues and PRs related to the test runner subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions