-
-
Notifications
You must be signed in to change notification settings - Fork 32k
typings: add typing for string decoder #38229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -51,6 +51,14 @@ const kNativeDecoder = Symbol('kNativeDecoder'); | |||||||
|
||||||||
// Do not cache `Buffer.isEncoding` when checking encoding names as some | ||||||||
// modules monkey-patch it to support additional encodings | ||||||||
/** | ||||||||
* Normalize encoding notation | ||||||||
* | ||||||||
* @param {string} enc | ||||||||
* @returns {"utf8" | "utf16le" | "hex" | "ascii" | ||||||||
* | "base64" | "latin1" | "base64url"} | ||||||||
* @throws {TypeError} Throws an error when encoding is invalid | ||||||||
*/ | ||||||||
function normalizeEncoding(enc) { | ||||||||
const nenc = internalUtil.normalizeEncoding(enc); | ||||||||
if (nenc === undefined) { | ||||||||
|
@@ -65,15 +73,27 @@ const encodingsMap = {}; | |||||||
for (let i = 0; i < encodings.length; ++i) | ||||||||
encodingsMap[encodings[i]] = i; | ||||||||
|
||||||||
// StringDecoder provides an interface for efficiently splitting a series of | ||||||||
// buffers into a series of JS strings without breaking apart multi-byte | ||||||||
// characters. | ||||||||
/** | ||||||||
* StringDecoder provides an interface for efficiently splitting a series of | ||||||||
* buffers into a series of JS strings without breaking apart multi-byte | ||||||||
* characters. | ||||||||
* | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Move the above description inside the comment? |
||||||||
* @param {string} [encoding=utf-8] | ||||||||
*/ | ||||||||
function StringDecoder(encoding) { | ||||||||
this.encoding = normalizeEncoding(encoding); | ||||||||
this[kNativeDecoder] = Buffer.alloc(kSize); | ||||||||
this[kNativeDecoder][kEncodingField] = encodingsMap[this.encoding]; | ||||||||
} | ||||||||
|
||||||||
/** | ||||||||
* Returns a decoded string, omitting any incomplete multi-bytes | ||||||||
* characters at the end of the Buffer, or TypedArray, or DataView | ||||||||
* | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
* @param {string | Buffer | TypedArray | DataView} buf | ||||||||
* @returns {string} | ||||||||
* @throws {TypeError} Throws when buf is not in one of supported types | ||||||||
*/ | ||||||||
StringDecoder.prototype.write = function write(buf) { | ||||||||
if (typeof buf === 'string') | ||||||||
return buf; | ||||||||
|
@@ -84,6 +104,14 @@ StringDecoder.prototype.write = function write(buf) { | |||||||
return decode(this[kNativeDecoder], buf); | ||||||||
}; | ||||||||
|
||||||||
/** | ||||||||
* Returns any remaining input stored in the internal buffer as a string. | ||||||||
* After end() is called, the stringDecoder object can be reused for new | ||||||||
* input. | ||||||||
* | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
* @param {string | Buffer | TypedArray | DataView} [buf] | ||||||||
* @returns {string} | ||||||||
*/ | ||||||||
StringDecoder.prototype.end = function end(buf) { | ||||||||
let ret = ''; | ||||||||
if (buf !== undefined) | ||||||||
|
@@ -94,6 +122,12 @@ StringDecoder.prototype.end = function end(buf) { | |||||||
}; | ||||||||
|
||||||||
/* Everything below this line is undocumented legacy stuff. */ | ||||||||
/** | ||||||||
* | ||||||||
* @param {string | Buffer | TypedArray | DataView} buf | ||||||||
* @param {number} offset | ||||||||
* @returns {string} | ||||||||
*/ | ||||||||
StringDecoder.prototype.text = function text(buf, offset) { | ||||||||
this[kNativeDecoder][kMissingBytes] = 0; | ||||||||
this[kNativeDecoder][kBufferedBytes] = 0; | ||||||||
|
Uh oh!
There was an error while loading. Please reload this page.