module: unflag --experimental-strip-types #56350

marco-ippolito · 2024-12-24T15:04:02Z

It's time to enable it by default to catch some more bugs, currently there are no open issues.
I think it's a semver minor change.

Fixes: nodejs/typescript#17

@nodejs/tsc for visibility

Notable change section:

This change enables the flag --experimental-strip-types by default.
Node.js will be able to execute TypeScript files without additional configuration. Note that there are some limitations in the supported syntax documented at https://nodejs.org/api/typescript.html#type-stripping
This feature is experimental and is subject to change.

nodejs-github-bot · 2024-12-24T15:04:07Z

Review requested:

@nodejs/loaders
@nodejs/performance
@nodejs/test_runner
@nodejs/typescript

codecov · 2024-12-24T19:38:19Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.54%. Comparing base (da3f388) to head (d847c32).
Report is 1102 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56350      +/-   ##
==========================================
- Coverage   88.54%   88.54%   -0.01%     
==========================================
  Files         657      657              
  Lines      190655   190658       +3     
  Branches    36582    36584       +2     
==========================================
- Hits       168824   168820       -4     
- Misses      15008    15011       +3     
- Partials     6823     6827       +4

Files with missing lines	Coverage Δ
src/node_options.cc	`87.92% <ø> (ø)`
src/node_options.h	`98.30% <100.00%> (ø)`

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina

LGTM

github-actions · 2024-12-25T12:09:44Z

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @marco-ippolito.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot · 2024-12-25T12:12:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/64202/

bmuenzenmeyer

excited for this, having watched it's development and played with it quite a bit.
some suggestions and questions, none blocking

doc/api/cli.md

test/es-module/test-typescript.mjs

test/parallel/test-runner-coverage-default-exclusion.mjs

doc/api/cli.md

doc/api/typescript.md

anonrig · 2024-12-26T00:03:35Z

What about process.features.typescript? Does that also needs changing?

marco-ippolito · 2024-12-26T06:05:36Z

What about process.features.typescript? Does that also needs changing?

It works fine, tests are updated (now the default value is 'strip')

ffMathy · 2025-01-09T12:55:41Z

It's kind of crazy that this was made as a minor release. Other than the linked issues, our Vitest tests in VS Code are not working anymore if we use this version.

JakobJingleheimer · 2025-01-09T13:07:47Z

It's kind of crazy that this was made as a minor release. Other than the linked issues, our Vitest tests in VS Code are not working anymore if we use this version.

This was around flagged for quite some time and no issues were reported. I believe we were not aware of a scenario were it could break without users changing something. Please open an issue, and please ensure there is more detail than "our Vitest tests in VS Code are not working" 🙂

pmarchini · 2025-01-09T13:08:05Z

Hey @ffMathy you can still disable the feature passing --no-experimental-strip-types (https://nodejs.org/api/cli.html#--no-experimental-strip-types)

ffMathy · 2025-01-09T14:00:47Z

But since I am relying on an external tool (Vitest), I am not sure how I tell it to disable this feature. It probably even doesn't support that flag.

marco-ippolito · 2025-01-09T14:05:21Z

You can do (maybe):

NODE_OPTIONS=--no-experimental-strip-types vitest

You might want to open an issue on vitest.

Notable changes: lib: * (SEMVER-MINOR) add typescript support to STDIN eval (Marco Ippolito) nodejs#56359 module: * (SEMVER-MINOR) unflag --experimental-strip-types (Marco Ippolito) nodejs#56350 process: * (SEMVER-MINOR) add process.ref() and process.unref() methods (James M Snell) nodejs#56400 worker: * (SEMVER-MINOR) add eval ts input (Marco Ippolito) nodejs#56394 PR-URL: nodejs#56450

PR-URL: nodejs#56350 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>

## Summary  Node.js v23.6 has unflagged the `--experimental-strip-types` feature (nodejs/node#56350). Instead of relying solely on this flag, it’s recommended to also check the standard `process.feature.typescript` to confirm native TypeScript support. > [!NOTE] > It will be backport to v22 soon. See: nodejs/node#57298  ## Checklist  - [x] Tests updated (or not required). - [x] Documentation updated (or not required).

PR-URL: nodejs#56350 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>

PR-URL: #58732 Refs: #56350 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#56350 Fixes: nodejs/typescript#17 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Pietro Marchini <[email protected]>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Dec 24, 2024

marco-ippolito added strip-types Issues or PRs related to strip-types support blocked PRs that are blocked by other issues or PRs. wip Issues and PRs that are still a work in progress. labels Dec 24, 2024

marco-ippolito force-pushed the unflag-strip-types branch from 7505688 to 72e089c Compare December 24, 2024 16:50

marco-ippolito marked this pull request as ready for review December 24, 2024 18:17

marco-ippolito removed wip Issues and PRs that are still a work in progress. blocked PRs that are blocked by other issues or PRs. labels Dec 24, 2024

marco-ippolito added semver-minor PRs that contain new features and should be released in the next minor version. dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Dec 25, 2024

mcollina approved these changes Dec 25, 2024

View reviewed changes

marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. notable-change PRs with changes that should be highlighted in changelogs. baking-for-lts PRs that need to wait before landing in a LTS release. labels Dec 25, 2024

marco-ippolito added the module Issues and PRs related to the module subsystem. label Dec 25, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2024

bmuenzenmeyer reviewed Dec 25, 2024

View reviewed changes

doc/api/cli.md Outdated Show resolved Hide resolved

doc/api/cli.md Show resolved Hide resolved

test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved

test/parallel/test-runner-coverage-default-exclusion.mjs Show resolved Hide resolved

aduh95 reviewed Dec 25, 2024

View reviewed changes

doc/api/cli.md Show resolved Hide resolved

doc/api/cli.md Outdated Show resolved Hide resolved

doc/api/typescript.md Show resolved Hide resolved

VoltrexKeyva approved these changes Dec 25, 2024

View reviewed changes

module: unflag --experimental-strip-types

d847c32

marco-ippolito force-pushed the unflag-strip-types branch from c28ef27 to d847c32 Compare December 26, 2024 06:41

marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2024

SwederellNF mentioned this pull request Jan 9, 2025

[Bug]: NodeJS 23.6.0 breaks tests using Typescript enums microsoft/playwright#34263

Closed

ffMathy mentioned this pull request Jan 15, 2025

Node 23.6 breaks event hub ftrackhq/ftrack-javascript#284

Closed

marco-ippolito added the backport-open-v22.x Indicate that the PR has an open backport label Mar 3, 2025

marco-ippolito mentioned this pull request Mar 3, 2025

[v22.x backport] module: unflag --experimental-strip-types #57298

Open

colinaaa mentioned this pull request Apr 5, 2025

feat(rspeedy/core): use process.features.typescript lynx-family/lynx-stack#481

Merged

2 tasks

AbhiPrasad mentioned this pull request Apr 14, 2025

Node 24 Support getsentry/sentry-javascript#16058

Closed

aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed backport-open-v22.x Indicate that the PR has an open backport labels May 6, 2025

theoludwig mentioned this pull request May 7, 2025

Revert "test_runner: change ts default glob" #58202

Merged

aduh95 added backport-open-v22.x Indicate that the PR has an open backport and removed backported-to-v22.x PRs backported to the v22.x-staging branch. labels May 19, 2025

aduh95 mentioned this pull request Jun 16, 2025

doc: add history entry for TS support in hooks #58732

Merged

benmccann mentioned this pull request Jun 28, 2025

feat: Support svelte.config.ts sveltejs/kit#13935

Open

6 tasks

Uh oh!

module: unflag --experimental-strip-types #56350

module: unflag --experimental-strip-types #56350

Conversation

marco-ippolito commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Dec 24, 2024

Uh oh!

codecov bot commented Dec 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 25, 2024

Uh oh!

nodejs-github-bot commented Dec 25, 2024

Uh oh!

bmuenzenmeyer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anonrig commented Dec 26, 2024

Uh oh!

marco-ippolito commented Dec 26, 2024

Uh oh!

ffMathy commented Jan 9, 2025

Uh oh!

JakobJingleheimer commented Jan 9, 2025

Uh oh!

pmarchini commented Jan 9, 2025

Uh oh!

ffMathy commented Jan 9, 2025

Uh oh!

marco-ippolito commented Jan 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

marco-ippolito commented Dec 24, 2024 •

edited

Loading

codecov bot commented Dec 24, 2024 •

edited

Loading

marco-ippolito commented Jan 9, 2025 •

edited

Loading