Skip to content

test: remove unnecessary assert requiring from tests #57008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

test: remove unnecessary assert requiring from tests #57008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/node-api/test_uv_threadpool_size/node-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const filePath = path.join(__dirname, `./build/${common.buildType}/test_uv_threa
const code = `
const { test } = require(${JSON.stringify(filePath)});
const size = parseInt(process.env.UV_THREADPOOL_SIZE, 10);
require('assert').strictEqual(size, 4);
assert.strictEqual(size, 4);
test(size);
`.trim();
const child = spawnSync(
Expand Down
21 changes: 10 additions & 11 deletions test/parallel/test-dotenv-edge-cases.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const noFinalNewlineSingleQuotesEnvFilePath = '../fixtures/dotenv/no-final-newli
describe('.env supports edge cases', () => {
it('supports multiple declarations, including optional ones', async () => {
const code = `
const assert = require('assert');
assert.strictEqual(process.env.BASIC, 'basic');
assert.strictEqual(process.env.NODE_NO_WARNINGS, '1');
`.trim();
Expand All @@ -41,7 +40,7 @@ describe('.env supports edge cases', () => {

it('supports absolute paths', async () => {
const code = `
require('assert').strictEqual(process.env.BASIC, 'basic');
assert.strictEqual(process.env.BASIC, 'basic');
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand All @@ -53,7 +52,7 @@ describe('.env supports edge cases', () => {

it('supports a space instead of \'=\' for the flag ', async () => {
const code = `
require('assert').strictEqual(process.env.BASIC, 'basic');
assert.strictEqual(process.env.BASIC, 'basic');
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand All @@ -66,7 +65,7 @@ describe('.env supports edge cases', () => {

it('should handle non-existent .env file', async () => {
const code = `
require('assert').strictEqual(1, 1)
assert.strictEqual(1, 1)
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand All @@ -79,7 +78,7 @@ describe('.env supports edge cases', () => {

it('should handle non-existent optional .env file', async () => {
const code = `
require('assert').strictEqual(1,1);
assert.strictEqual(1,1);
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand All @@ -92,8 +91,8 @@ describe('.env supports edge cases', () => {

it('should not override existing environment variables but introduce new vars', async () => {
const code = `
require('assert').strictEqual(process.env.BASIC, 'existing');
require('assert').strictEqual(process.env.AFTER_LINE, 'after_line');
assert.strictEqual(process.env.BASIC, 'existing');
assert.strictEqual(process.env.AFTER_LINE, 'after_line');
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand Down Expand Up @@ -124,8 +123,8 @@ describe('.env supports edge cases', () => {
// Ref: https://github.com/nodejs/node/issues/52466
const code = `
process.loadEnvFile('./eof-without-value.env');
require('assert').strictEqual(process.env.BASIC, 'value');
require('assert').strictEqual(process.env.EMPTY, '');
assert.strictEqual(process.env.BASIC, 'value');
assert.strictEqual(process.env.EMPTY, '');
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand Down Expand Up @@ -160,7 +159,7 @@ describe('.env supports edge cases', () => {
const child = await common.spawnPromisified(
process.execPath,
[
'--eval', `require('assert').strictEqual(process.env.BASIC, undefined);`,
'--eval', `assert.strictEqual(process.env.BASIC, undefined);`,
'--', '--env-file', validEnvFilePath,
],
{ cwd: __dirname },
Expand All @@ -172,7 +171,7 @@ describe('.env supports edge cases', () => {

it('should handle file without a final newline', async () => {
const code = `
require('assert').strictEqual(process.env.BASIC, 'basic');
assert.strictEqual(process.env.BASIC, 'basic');
`.trim();
const child = await common.spawnPromisified(
process.execPath,
Expand Down
Loading