-
-
Notifications
You must be signed in to change notification settings - Fork 32k
esm: syncify default path of ModuleLoader.load
#57419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fc540c2
fffcc31
cdeb423
d78eb9f
8630ad7
ce7fd9c
257f480
11d543b
f6a8cd0
6f910e4
a31d408
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -806,9 +806,9 @@ class ModuleLoader { | |
* if any. | ||
* @param {string} url The URL of the module to be loaded. | ||
* @param {object} context Metadata about the module | ||
* @returns {Promise<{ format: ModuleFormat, source: ModuleSource }>} | ||
* @returns {Promise<{ format: ModuleFormat, source: ModuleSource }> | { format: ModuleFormat, source: ModuleSource }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think that this can be fully synchronous if it uses There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Ack, nvmd. No. |
||
*/ | ||
async load(url, context) { | ||
load(url, context) { | ||
if (loadHooks.length) { | ||
// Has module.registerHooks() hooks, use the synchronous variant that can handle both hooks. | ||
return this.#loadSync(url, context); | ||
|
Uh oh!
There was an error while loading. Please reload this page.