Skip to content

win: fix SIGQUIT on ClangCL #57659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
+3 −4
Merged

win: fix SIGQUIT on ClangCL #57659

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@
#endif

#ifdef _WIN32
# define SIGKILL 9
#define SIGQUIT 3
#define SIGKILL 9
#endif

#include "v8.h" // NOLINT(build/include_order)
Expand Down
4 changes: 1 addition & 3 deletions test/parallel/test-child-process-kill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ assert.strictEqual(cat.killed, true);

// Test different types of kill signals on Windows.
if (common.isWindows) {
// SIGQUIT is not supported on Windows 2022, Visual Studio 2022 ClangCL-produced node.exe.
// TODO(StefanStojanovic): Investigate this and re-enable it when the issue is fixed.
for (const sendSignal of ['SIGTERM', 'SIGKILL', /* 'SIGQUIT', */'SIGINT']) {
for (const sendSignal of ['SIGTERM', 'SIGKILL', 'SIGQUIT', 'SIGINT']) {
const process = spawn('cmd');
process.on('exit', (code, signal) => {
assert.strictEqual(code, null);
Expand Down
Loading