-
-
Notifications
You must be signed in to change notification settings - Fork 32k
tools: edit create-release-proposal workflow to handle pr body length #57841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nodejs-github-bot
merged 3 commits into
nodejs:main
from
elvessilvavieira:actions/tools-update-release-proposal-creator
Apr 14, 2025
Merged
tools: edit create-release-proposal workflow to handle pr body length #57841
nodejs-github-bot
merged 3 commits into
nodejs:main
from
elvessilvavieira:actions/tools-update-release-proposal-creator
Apr 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
RafaelGSS
approved these changes
Apr 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aduh95
reviewed
Apr 11, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Apr 12, 2025
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Apr 12, 2025
RafaelGSS
approved these changes
Apr 13, 2025
Commit Queue failed- Loading data for nodejs/node/pull/57841 ✔ Done loading data for nodejs/node/pull/57841 ----------------------------------- PR info ------------------------------------ Title tools: edit create-release-proposal workflow to handle pr body length (#57841) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch elvessilvavieira:actions/tools-update-release-proposal-creator -> nodejs:main Labels tools, author ready Commits 3 - tools: edit create-release-proposal workflow to handle pr body length - tools: improve performance of PR body length handling - tools: fix create-release-proposal workflow Committers 1 - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 11 Apr 2025 21:15:42 GMT ✔ Approvals: 2 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762514063 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762268610 ✘ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14433474286 |
oh... I just update it. it should now be visible |
Landed in 958fd91 |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 5, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jun 11, 2025
PR-URL: #57841 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub actions does not allow a body greater than 65536. Therefore, if it exceeds this, it only write the RELEASE_DATE
@RafaelGSS could you pls review it? thx