Skip to content

tools: edit create-release-proposal workflow to handle pr body length #57841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

elvessilvavieira
Copy link
Contributor

GitHub actions does not allow a body greater than 65536. Therefore, if it exceeds this, it only write the RELEASE_DATE

@RafaelGSS could you pls review it? thx

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 11, 2025
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2025
@RafaelGSS RafaelGSS requested a review from a team April 11, 2025 22:05
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 13, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/57841
✔  Done loading data for nodejs/node/pull/57841
----------------------------------- PR info ------------------------------------
Title      tools: edit create-release-proposal workflow to handle pr body length (#57841)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     elvessilvavieira:actions/tools-update-release-proposal-creator -> nodejs:main
Labels     tools, author ready
Commits    3
 - tools: edit create-release-proposal workflow to handle pr body length
 - tools: improve performance of PR body length handling
 - tools: fix create-release-proposal workflow
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/57841
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57841
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 11 Apr 2025 21:15:42 GMT
   ✔  Approvals: 2
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762514063
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57841#pullrequestreview-2762268610
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14433474286

@elvessilvavieira
Copy link
Contributor Author

Commit Queue failed

oh... I just update it. it should now be visible

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 14, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2025
@nodejs-github-bot nodejs-github-bot merged commit 958fd91 into nodejs:main Apr 14, 2025
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 958fd91

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
aduh95 pushed a commit that referenced this pull request May 6, 2025
aduh95 pushed a commit that referenced this pull request May 6, 2025
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
aduh95 pushed a commit that referenced this pull request May 16, 2025
aduh95 pushed a commit that referenced this pull request May 17, 2025
aduh95 pushed a commit that referenced this pull request May 17, 2025
aduh95 pushed a commit that referenced this pull request May 17, 2025
aduh95 pushed a commit that referenced this pull request May 18, 2025
aduh95 pushed a commit that referenced this pull request May 19, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants