Skip to content

buffer: move SlowBuffer to EOL #58220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2025
Merged

buffer: move SlowBuffer to EOL #58220

merged 1 commit into from
May 9, 2025

Conversation

panva
Copy link
Member

@panva panva commented May 7, 2025

This re-lands #58008 for the next semver-major PRs that contain breaking changes and should be released in the next major version. as originally intended.

cc @jasnell

@panva panva added the semver-major PRs that contain breaking changes and should be released in the next major version. label May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config
  • @nodejs/performance
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels May 7, 2025
@panva panva force-pushed the eol-slowbuffer-25 branch from 93dca6c to fad805b Compare May 7, 2025 19:34
@panva panva marked this pull request as ready for review May 7, 2025 19:34
@panva panva added the deprecations Issues and PRs related to deprecations. label May 7, 2025
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 7, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66694/

@aduh95
Copy link
Contributor

aduh95 commented May 7, 2025

Can you add This commits reverts da69d13623e6c9ec8692d8002297e63cf2f656d8 in the commit message please?

@codecov Codecov
Copy link

codecov bot commented May 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (da69d13) to head (c1f17c8).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58220      +/-   ##
==========================================
- Coverage   90.12%   90.12%   -0.01%     
==========================================
  Files         629      629              
  Lines      186638   186622      -16     
  Branches    36618    36616       -2     
==========================================
- Hits       168210   168189      -21     
- Misses      11215    11220       +5     
  Partials     7213     7213
Files with missing lines Coverage Δ
lib/buffer.js 100.00% <100.00%> (ø)
src/node_options.cc 85.23% <ø> (ø)

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva force-pushed the eol-slowbuffer-25 branch from fad805b to c1f17c8 Compare May 8, 2025 11:14
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2025
@panva
Copy link
Member Author

panva commented May 8, 2025

Can you add This commits reverts da69d13623e6c9ec8692d8002297e63cf2f656d8 in the commit message please?

done

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66707/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66722/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
mcollina
mcollina approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit daced4a into nodejs:main May 9, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in daced4a

@panva panva deleted the eol-slowbuffer-25 branch May 10, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@gurgunday gurgunday gurgunday approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.