Skip to content

inspector: add protocol methods retrieving sent/received data #58645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

legendecas
Copy link
Member

Add protocol method Network.dataSent to buffer request data. And
expose protocol methods Network.getRequestPostData and
Network.getResponseBody allowing devtool to retrieve buffered data.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 9, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.
@legendecas legendecas force-pushed the inspector/data-sent-api branch from 0d15711 to 5b2f8a5 Compare June 9, 2025 11:56
@legendecas legendecas added the inspector Issues and PRs related to the V8 inspector protocol label Jun 9, 2025
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 80.12048% with 33 lines in your changes missing coverage. Please review.

Project coverage is 90.15%. Comparing base (b23648e) to head (5b2f8a5).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
src/inspector/network_agent.cc 68.31% 16 Missing and 16 partials ⚠️
lib/internal/inspector/network.js 95.23% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #58645    +/-   ##
========================================
  Coverage   90.15%   90.15%            
========================================
  Files         636      637     +1     
  Lines      187891   188001   +110     
  Branches    36879    36899    +20     
========================================
+ Hits       169386   169493   +107     
+ Misses      11272    11245    -27     
- Partials     7233     7263    +30     
Files with missing lines Coverage Δ
lib/inspector.js 96.94% <100.00%> (+0.01%) ⬆️
lib/internal/inspector/network_http.js 95.23% <100.00%> (+0.68%) ⬆️
lib/internal/inspector/network_undici.js 94.40% <100.00%> (+0.65%) ⬆️
src/inspector/network_agent.h 100.00% <100.00%> (ø)
lib/internal/inspector/network.js 94.66% <95.23%> (+0.22%) ⬆️
src/inspector/network_agent.cc 63.47% <68.31%> (-0.31%) ⬇️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@legendecas
Copy link
Member Author

@nodejs/inspector would you mind taking a look? Thank you!

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 5a14ea6 into nodejs:main Jun 20, 2025
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5a14ea6

@legendecas legendecas deleted the inspector/data-sent-api branch June 20, 2025 10:34
RafaelGSS pushed a commit that referenced this pull request Jun 23, 2025
Add protocol method `Network.dataSent` to buffer request data. And
expose protocol methods `Network.getRequestPostData` and
`Network.getResponseBody` allowing devtool to retrieve buffered data.

PR-URL: #58645
Reviewed-By: Ryuhei Shima <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants