Skip to content

test: add known issue tests for fs.cp #58883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: add known issue tests for fs.cp #58883

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 29, 2025 •
edited
Loading

Refs: #58634
Refs: #58869

@nodejs/fs

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 29, 2025
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
jasnell
jasnell commented Jun 29, 2025
View reviewed changes
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 29, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/67713/ 💛

@jasnell jasnell added the fs Issues and PRs related to the fs subsystem / file system. label Jun 29, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 29, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.09%. Comparing base (4d5ee24) to head (3339b0c).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58883      +/-   ##
==========================================
- Coverage   90.10%   90.09%   -0.02%     
==========================================
  Files         640      640              
  Lines      188493   188493              
  Branches    36971    36972       +1     
==========================================
- Hits       169843   169820      -23     
- Misses      11358    11401      +43     
+ Partials     7292     7272      -20

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dario-piotrowicz
dario-piotrowicz approved these changes Jun 29, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

Shall we create some tests for readdir as well? (#58634 (comment))

If you prefer I can also do that as a followup (should I actually create a dedicated GitHub issue for readdir? 🤔)

@jasnell
Copy link
Member Author

jasnell commented Jun 29, 2025

Yeah, an issue and set of known issue tests would be good

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 29, 2025
@dario-piotrowicz
Copy link
Member

Yeah, an issue and set of known issue tests would be good

Done 🙂👍

#58892
#58893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jazelly jazelly jazelly approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@anonrig anonrig Awaiting requested review from anonrig

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @dario-piotrowicz @lpinca @jazelly @VoltrexKeyva @LiviaMedeiros