Skip to content

src: fix a series of -Wno-unreachable-code errors #58901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

src: fix a series of -Wno-unreachable-code errors #58901

wants to merge 4 commits into from
+6 −8

Conversation

codebytere
Copy link
Member

Tweaks to fix the following:

  • -Wno-unreachable-code
  • -Wno-unreachable-code-break
  • -Wno-unreachable-code-return

@codebytere codebytere requested a review from jasnell June 30, 2025 09:59
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/node-api

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 30, 2025
@codebytere codebytere force-pushed the fix-compile-errors branch from b5b4d51 to c6a8fa3 Compare June 30, 2025 10:11
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (8b199ee) to head (c6a8fa3).
Report is 27 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58901   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files         640      640           
  Lines      188426   188426           
  Branches    36955    36959    +4     
=======================================
+ Hits       169796   169800    +4     
+ Misses      11351    11337   -14     
- Partials     7279     7289   +10
Files with missing lines Coverage Δ
src/crypto/crypto_context.cc 69.16% <ø> (ø)
src/node_api.cc 76.16% <ø> (ø)
src/node_config_file.cc 80.55% <ø> (ø)
src/node_contextify.cc 81.24% <ø> (ø)

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67754/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67759/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67781/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67838/

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 4, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 4, 2025
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere @nodejs-github-bot
src: fix -Wunreachable-code in src/node_api.cc
06b0987 
PR-URL: #58901
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

Landed in 560d00f...813b4e8

nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere @nodejs-github-bot
src: fix -Wunreachable-code-return in src/node_contextify.cc
f2ca1ec 
PR-URL: #58901
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere @nodejs-github-bot
src: -Wunreachable-code error in crypto_context.cc
51d9f3f 
PR-URL: #58901
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jul 4, 2025
@codebytere @nodejs-github-bot
src: -Wunreachable-code-break in node_config_file.cc
813b4e8 
PR-URL: #58901
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Vladimir Morozov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@vmoroz vmoroz vmoroz approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @jasnell @addaleax @vmoroz @legendecas