-
-
Notifications
You must be signed in to change notification settings - Fork 32k
lib: expose global ErrorEvent #58920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58920 +/- ##
==========================================
- Coverage 90.11% 90.08% -0.03%
==========================================
Files 640 640
Lines 188427 188473 +46
Branches 36956 36971 +15
==========================================
- Hits 169792 169777 -15
- Misses 11348 11423 +75
+ Partials 7287 7273 -14
🚀 New features to boost your workflow:
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
cc @nodejs/tsc for
semver-major
|
@KhafraDev Is the class is tested in https://github.com/nodejs/undici inclusive all its related WPTs? Are there ErrorEvent WPTs we could enable in https://github.com/nodejs/node? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some form of test coverage should be present here.
It is tested, but all of the WPTs iirc were html files, so I adapted them to run in our own test suite. There isn't anything node needs to enable. It should be safe to assume that, similar to everything else from undici, it follows the spec even closer than pretty much anything in node core. https://github.com/nodejs/undici/blob/main/test/websocket/events.js |
Fixes #58918