Skip to content

lib: flag to conditionally modify proto on deprecate #58928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RafaelGSS
Copy link
Member

Refs: #58218

In this specific benchmark, the performance difference between modifyPrototype=0 and modifyPrototype=1 is marginally significant at the 5% level:

  • Mean (modifyPrototype=0): 390,196.99 ops/sec
  • Mean (modifyPrototype=1): 382,521.21 ops/sec
  • p-value: 0.05087

While this case is borderline, other benchmarks (e.g., #58907) have shown a more noticeable improvement, so I think this worth the change.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/performance

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jul 2, 2025
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.07%. Comparing base (a7a37c3) to head (b782bc8).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58928      +/-   ##
==========================================
- Coverage   90.11%   90.07%   -0.04%     
==========================================
  Files         640      640              
  Lines      188427   188466      +39     
  Branches    36956    36969      +13     
==========================================
- Hits       169792   169765      -27     
- Misses      11348    11426      +78     
+ Partials     7287     7275      -12     
Files with missing lines Coverage Δ
lib/internal/util.js 96.16% <100.00%> (-0.68%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@RafaelGSS RafaelGSS added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues that need assistance from volunteers or PRs that need help to proceed. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants