Skip to content

doc: move "Core Promise APIs" to "Completed initiatives" #58934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 2, 2025

There haven't been much more progress, it seems safe to assume what could realistically be done has been done.

Closes: nodejs/TSC#1094

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 2, 2025
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 2, 2025
@ljharb
Copy link
Member

ljharb commented Jul 2, 2025

it'd be nice to get child_process done before calling it "completed"; i've had it on my list to do but haven't made time yet.

@jasnell
Copy link
Member

jasnell commented Jul 2, 2025

@ljharb ... there's really nothing preventing continued work. This is really just to remove it from the brief review we have of these during the TSC meetings. This was initially added as a strategic initiative many years ago when it was still controversial that we would adopt promises widely at all. Since then it's been a steady stream of "no updates" reports in the TSC meetings that don't really have any value.

@joyeecheung
Copy link
Member

Note that it can be brought back to the ongoing list again if you have work that you want to report/get feedback from the TSC for a sustained period (for one-off TSC intervention requests, tagging tsc-agenda would suffice. Though I don't expect TSC oversight to be necessary for work in this line). @ljharb

@ljharb
Copy link
Member

ljharb commented Jul 2, 2025

ah ok, gotcha. i'll keep it on my list then :-) thanks!

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aduh95
Copy link
Contributor Author

aduh95 commented Jul 3, 2025

@ljharb yeah you're most welcome to keep working on it, just so you know a satisfying async API would probably require some changes at the libuv level – JS only solutions tend to struggle to get traction/consensus, e.g. #45774

@LiviaMedeiros LiviaMedeiros changed the title doc: more "Core Promise APIs" to "Completed initiatives" doc: move "Core Promise APIs" to "Completed initiatives" Jul 3, 2025
Copy link
Member

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; this might need s/more/move/ in the commit message

@aduh95 aduh95 merged commit 19876f4 into nodejs:main Jul 4, 2025
23 checks passed
@aduh95
Copy link
Contributor Author

aduh95 commented Jul 4, 2025

Landed in 19876f4

@aduh95 aduh95 deleted the retire-core-promises-strategic-init branch July 4, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core Promise Initiative status