Skip to content

worker: add worker name to report #58935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

theanarkh
Copy link
Contributor

Add worker name to report.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. worker Issues and PRs related to Worker support. labels Jul 2, 2025
@theanarkh theanarkh force-pushed the add_worker_name_to_report branch from 0694c03 to ca2fa61 Compare July 2, 2025 17:52
@theanarkh theanarkh force-pushed the add_worker_name_to_report branch from ca2fa61 to 9ec7bae Compare July 2, 2025 17:53
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (ba8fbf3) to head (9ec7bae).
Report is 998 commits behind head on main.

Files with missing lines Patch % Lines
src/node_report.cc 0.00% 2 Missing ⚠️
src/node_worker.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58935      +/-   ##
==========================================
- Coverage   90.37%   90.05%   -0.32%     
==========================================
  Files         629      640      +11     
  Lines      184373   188474    +4101     
  Branches    36022    36971     +949     
==========================================
+ Hits       166624   169737    +3113     
- Misses      10906    11459     +553     
- Partials     6843     7278     +435     
Files with missing lines Coverage Δ
src/node_worker.h 83.33% <0.00%> (-7.58%) ⬇️
src/node_report.cc 91.07% <0.00%> (-2.16%) ⬇️

... and 322 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants