Skip to content

os: fix GetInterfaceAddresses memory leaky #58940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2025
Merged

os: fix GetInterfaceAddresses memory leaky #58940

merged 1 commit into from
Jul 5, 2025
+3 −1

Conversation

theanarkh
Copy link
Contributor

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem. labels Jul 3, 2025
juanarbol
juanarbol approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@theanarkh theanarkh force-pushed the fix_GetInterfaceAddresses_memory_leaky branch from 662ef66 to 3b11dbf Compare July 3, 2025 01:25
@codecov Codecov
Copy link

codecov bot commented Jul 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.08%. Comparing base (ba8fbf3) to head (3b11dbf).
Report is 998 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58940      +/-   ##
==========================================
- Coverage   90.37%   90.08%   -0.29%     
==========================================
  Files         629      640      +11     
  Lines      184373   188473    +4100     
  Branches    36022    36972     +950     
==========================================
+ Hits       166624   169783    +3159     
- Misses      10906    11422     +516     
- Partials     6843     7268     +425
Files with missing lines Coverage Δ
src/node_os.cc 80.00% <100.00%> (+1.26%) ⬆️

... and 322 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67840/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67851/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67854/

@theanarkh theanarkh added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit b890c51 into nodejs:main Jul 5, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b890c51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. os Issues and PRs related to the os subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theanarkh @nodejs-github-bot @legendecas @juanarbol