Skip to content

fix(table): only apply border to immediate td children #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

avivkeller
Copy link
Member

Fixes a bug where tables-in-tables wouldn't have their borders applied correctly:

Screenshot 2025-06-29 at 20 07 38

CC @ovflowd

@avivkeller avivkeller requested a review from a team as a code owner June 30, 2025 00:51
Copy link

vercel bot commented Jun 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 1, 2025 0:19am

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (3ab796a) to head (9f6445d).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7911      +/-   ##
==========================================
+ Coverage   75.35%   75.41%   +0.05%     
==========================================
  Files          96       96              
  Lines        8350     8354       +4     
  Branches      220      219       -1     
==========================================
+ Hits         6292     6300       +8     
+ Misses       2056     2052       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AugustinMauroy
Copy link
Member

I think we have a story for this css part maybe add one more test case

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 96 🟢 100 🟠 83 🔗
/en/download 🟢 96 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tysm <3

@avivkeller
Copy link
Member Author

@AugustinMauroy PTAL at the updated Story

@ovflowd
Copy link
Member

ovflowd commented Jul 1, 2025

Fast-tracking as a bug fix for api-docs-tooling!

@avivkeller avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Jul 1, 2025
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jul 1, 2025
@ovflowd ovflowd added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 6ce9ac9 Jul 1, 2025
19 checks passed
@ovflowd ovflowd deleted the fix/table-td-border branch July 1, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants