Fix: Provide body on retry error, preserve socket #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatal10110
force-pushed
the
fix_retry_handler
branch
3 times, most recently
from
230ec24 to
c48ed92
Compare
backward compatibility
fatal10110
force-pushed
the
fix_retry_handler
branch
from
c48ed92 to
58e326b
Compare
fatal10110
changed the title
|
I do not think CI failure is somehow related to this PR |
This was referenced May 21, 2025
Co-authored-by: Carlos Fuentes <[email protected]>
Co-authored-by: Carlos Fuentes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Trying to fix #4222
I didn't touch any ranged/partial content behaviour, as it is unexpected server response and I guess should really throw an error in this case.
Rationale
Currently retry-handler has two issues
Changes
Added a flag to make the handler react to "retry" callback result, and apply relevan functionality, instead of throwing the error immediately
Bug Fixes
#4222
Breaking Changes and Deprecations
in old flow, throw moved from onResponseStart to onResponseEnd which should not affect anyone as callbacks are not propogated
Status