-
Notifications
You must be signed in to change notification settings - Fork 39
#78 remove notebooks code reliant valkyrie #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
I will automatically update this comment whenever this PR is modified
|
PR to resolve failing tests: #81 |
notebooks/iceflow/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll want to have a pointer to the new iceflow library here. I can make some suggested changes directly - just wanted to add my comment in the meantime!
This distinguishes these notebooks from the iceflow library
Also move icepyx higher in the list
The changes look good to me! |
In the 01-introduction notebook the link to OpenAltimetry should be updated to: https://openaltimetry.earthdatacloud.nasa.gov/data/ Otherwise that notebook looks good to me! Still need to read through corrections. |
Nevermind about corrections notebook! I needed to read the description of the PR more carefully above. |
Good catch! There were some other outdated references as well, so I fixed those too. e0b0db5 |
@@ -0,0 +1,150 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "Altimetry Harmonization" the best title? I think it is misleading, the page does not give any information about harmonization, just background to the missions.
Introduce both this notebook and "corrections" notebook.
In section 1. we say the notebook is interactive but there is no code to interact with, it is just a text document. Suggest combing the two notebooks.
The "pre-IceBridge" flights seem like an add-on. If we are providing a chronological introduction to NASA Cryosphere Altimetry missions, then we should start with ATM.
None of these missions measure ice thickness directly, they measure land, vegetation, ice, sea ice and ocean surface heights. Thickness and change in thickness are derived products.
Suggest introducing the missions (sections 2.1 - 2.4) before discussing the differences in file formats and reference frames.
Need information on what the file formats are and how to read them.
I would also add a table of the ITRF that correspond to the four products, and any changes that have occurred.
Reply via ReviewNB
@asteiker and @trey-stafford , I wonder if the materials here could be incorporated into the iceflow notebooks. They seem to be isolated here. Alternatively, we could incorporate them into the NSIDC Data Cookbook. A path forward might be to merge this PR, assuming we are not losing any useful information, and then open an issue in the Cookbook to incorporate the material there. An alternative would be to incorporate the information into the UW E-Science ICESat-2 Cookbook. That said, we could do both. There is no harm in repetition or duplication |
From nsidc/NSIDC-Data-Tutorials#80. See related issue: #69
Migrated to the `iceflow` standalone repository in nsidc/iceflow#70
4ac2410
to
39bc777
Compare
39bc777
to
13075d9
Compare
Following discussions between myself and @asteiker, we decided to migrate the The top-level README for this repository has been updated to point users to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this was just removed then added (no changes)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the openaltimetry links in this notebook from http://openaltimetry.org/ to https://openaltimetry.earthdatacloud.nasa.gov/data.
Resolves #78
This removes all of the notebooks and code, except for:
01_introduction
notebook, which now only contains overview information about (pre)icebridge/icesat/icesat2 altimetry data. It does not provide any code for searching/accessing/harmonizing data.corrections
notebook. This remains unchanged, describing to users the importance of harmonizing the CRS of data across missions, and using a synthesized dataset as an examplecorrections
notebook in Add real-world example of dataset ITRF transformation #76