#78 remove notebooks code reliant valkyrie

[trey-stafford]

Resolves #78

This removes all of the notebooks and code, except for:

• The 01_introduction notebook, which now only contains overview information about (pre)icebridge/icesat/icesat2 altimetry data. It does not provide any code for searching/accessing/harmonizing data.
• The corrections notebook. This remains unchanged, describing to users the importance of harmonizing the CRS of data across missions, and using a synthesized dataset as an example
  • We will address adding a real-world example to the corrections notebook in Add real-world example of dataset ITRF transformation #76

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[github-actions]

👈 Launch a binder notebook on this branch for commit 6ec5ab2

I will automatically update this comment whenever this PR is modified

👈 Launch a binder notebook on this branch for commit 5d44168

👈 Launch a binder notebook on this branch for commit 4f3753e

👈 Launch a binder notebook on this branch for commit 50e3979

👈 Launch a binder notebook on this branch for commit f53fed5

👈 Launch a binder notebook on this branch for commit b0f2d0a

👈 Launch a binder notebook on this branch for commit e0b0db5

👈 Launch a binder notebook on this branch for commit 4ac2410

👈 Launch a binder notebook on this branch for commit 39bc777

👈 Launch a binder notebook on this branch for commit 13075d9

[trey-stafford]

PR to resolve failing tests: #81

[asteiker]

I think we'll want to have a pointer to the new iceflow library here. I can make some suggested changes directly - just wanted to add my comment in the meantime!

[betolink]

The changes look good to me!

[mikala-nsidc]

In the 01-introduction notebook the link to OpenAltimetry should be updated to:

https://openaltimetry.earthdatacloud.nasa.gov/data/

Otherwise that notebook looks good to me! Still need to read through corrections.

[mikala-nsidc]

Nevermind about corrections notebook! I needed to read the description of the PR more carefully above.

[trey-stafford]

In the 01-introduction notebook the link to OpenAltimetry should be updated to:

https://openaltimetry.earthdatacloud.nasa.gov/data/

Otherwise that notebook looks good to me! Still need to read through corrections.

Good catch! There were some other outdated references as well, so I fixed those too. e0b0db5

[andypbarrett]

Is "Altimetry Harmonization" the best title? I think it is misleading, the page does not give any information about harmonization, just background to the missions.

Introduce both this notebook and "corrections" notebook.

In section 1. we say the notebook is interactive but there is no code to interact with, it is just a text document. Suggest combing the two notebooks.

The "pre-IceBridge" flights seem like an add-on. If we are providing a chronological introduction to NASA Cryosphere Altimetry missions, then we should start with ATM.

None of these missions measure ice thickness directly, they measure land, vegetation, ice, sea ice and ocean surface heights. Thickness and change in thickness are derived products.

Suggest introducing the missions (sections 2.1 - 2.4) before discussing the differences in file formats and reference frames.

Need information on what the file formats are and how to read them.

I would also add a table of the ITRF that correspond to the four products, and any changes that have occurred.

Reply via ReviewNB

[andypbarrett]

@asteiker and @trey-stafford , I wonder if the materials here could be incorporated into the iceflow notebooks. They seem to be isolated here. Alternatively, we could incorporate them into the NSIDC Data Cookbook.

A path forward might be to merge this PR, assuming we are not losing any useful information, and then open an issue in the Cookbook to incorporate the material there.

An alternative would be to incorporate the information into the UW E-Science ICESat-2 Cookbook.

That said, we could do both. There is no harm in repetition or duplication

[trey-stafford]

Following discussions between myself and @asteiker, we decided to migrate the 0_introduction.ipynb and corrections.ipynb to the iceflow repository (see nsidc/iceflow#70).

The top-level README for this repository has been updated to point users to the iceflow repository and documentation. All other iceflow-related content has been removed.

[asteiker]

It looks like this was just removed then added (no changes)?

[trey-stafford]

I updated the openaltimetry links in this notebook from http://openaltimetry.org/ to https://openaltimetry.earthdatacloud.nasa.gov/data.