Fix onResponseError chain call #92
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method onResponseError doesn't work (also all
$http.interceptors.response
with errors handlers)This PR fix problem
How to reproduce:
playground/pages/index.vue
with above ($http.get should return 404 error code)With fix onResponseErrorWork will be true and console.log will call
Without fix onResponseErrorWork will be false, because onResponseError never called in chain after request handler interceptor
Without fix all calls with
$http.get
and others methods newer throw error (catch
never «catch»)