-
Notifications
You must be signed in to change notification settings - Fork 99
chore: bump @vue/composition-api, fix #244 #251
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/nuxt-community/composition-api/3e5g3fyrl |
Thanks @antfu ❤️ |
Any idea why the test fails? |
@antfu Looking into it. |
@antfu It's erroring because const a = reactive({})
Vue.set(a, 'prop', 'value') See https://codesandbox.io/s/wizardly-glitter-v9nd0?file=/pages/index.vue I'll see if I can remove it from |
@antfu - looks good to go from my point of view but I guess the question is whether you regard the changed behaviour of |
Thanks @antfu and @danielroe! Would love to see this merged so we can work out some of the bugs we're still dealing with! |
@danielroe Bumped the version to beta.16 and changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic - thanks so much for this ❤️
Guys, not sure if it is something that we should be concerned of, but after this update I started getting this friendly error: WARN in ./.nuxt/composition-api/index.js friendly-errors 11:08:50
"export '_set' (reexported as 'set') was not found in '@vue/composition-api' |
This warning should not appear in |
fix #244