Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

chore: bump @vue/composition-api, fix #244 #251

Merged
merged 6 commits into from
Oct 10, 2020
Merged

Conversation

antfu
Copy link
Contributor

@antfu antfu commented Oct 4, 2020

fix #244

@vercel
Copy link

vercel bot commented Oct 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxt-community/composition-api/3e5g3fyrl
✅ Preview: https://composition-api-git-main.nuxt-community.vercel.app

danielroe
danielroe previously approved these changes Oct 4, 2020
@danielroe
Copy link
Member

Thanks @antfu ❤️

@antfu
Copy link
Contributor Author

antfu commented Oct 4, 2020

Any idea why the test fails?

@danielroe
Copy link
Member

@antfu Looking into it.

@danielroe
Copy link
Member

danielroe commented Oct 4, 2020

@antfu It's erroring because Vue.set is now failing on reactive objects (but only on SSR):

const a = reactive({})
Vue.set(a, 'prop', 'value')

See https://codesandbox.io/s/wizardly-glitter-v9nd0?file=/pages/index.vue

I'll see if I can remove it from useMeta and then we should be good to go.

@danielroe
Copy link
Member

@antfu - looks good to go from my point of view but I guess the question is whether you regard the changed behaviour of Vue.set as a bug or not.

danielroe
danielroe previously approved these changes Oct 4, 2020
@aaronhuisinga
Copy link

Thanks @antfu and @danielroe! Would love to see this merged so we can work out some of the bugs we're still dealing with!

@antfu
Copy link
Contributor Author

antfu commented Oct 10, 2020

@danielroe Bumped the version to beta.16 and changed Vue.set to set from VCA. Should work fine now. You would also want to use set instead of Vue.set for most of the cases in the future. 😉

danielroe
danielroe previously approved these changes Oct 10, 2020
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic - thanks so much for this ❤️

@danielroe danielroe merged commit 317980b into nuxt-community:main Oct 10, 2020
@bissolli
Copy link

Guys, not sure if it is something that we should be concerned of, but after this update I started getting this friendly error:

 WARN  in ./.nuxt/composition-api/index.js                   friendly-errors 11:08:50

"export '_set' (reexported as 'set') was not found in '@vue/composition-api'

@danielroe
Copy link
Member

This warning should not appear in v0.13.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: vue warn toRefs() when using useMeta
4 participants